Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions cmd/initializer.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (

"github.com/kcp-dev/logicalcluster/v3"
"github.com/kcp-dev/multicluster-provider/initializingworkspaces"
pmcontext "github.com/platform-mesh/golang-commons/context"
"github.com/spf13/cobra"
"k8s.io/apimachinery/pkg/runtime"
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
Expand All @@ -28,9 +27,6 @@ var initializerCmd = &cobra.Command{
Use: "initializer",
Short: "FGA initializer for the organization workspacetype",
RunE: func(cmd *cobra.Command, args []string) error {
ctx, _, shutdown := pmcontext.StartContext(log, initializerCfg, defaultCfg.ShutdownTimeout)
defer shutdown()

restCfg, err := getKubeconfigFromPath(initializerCfg.KCP.Kubeconfig)
if err != nil {
log.Error().Err(err).Msg("unable to get KCP kubeconfig")
Expand Down Expand Up @@ -113,12 +109,6 @@ var initializerCmd = &cobra.Command{
os.Exit(1)
}

go func() {
if err := provider.Run(ctx, mgr); err != nil {
log.Fatal().Err(err).Msg("unable to run provider")
}
}()

setupLog.Info("starting manager")

return mgr.Start(ctrl.SetupSignalHandler())
Expand Down
14 changes: 6 additions & 8 deletions cmd/model_generator.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,12 @@ var modelGeneratorCmd = &cobra.Command{
return fmt.Errorf("scheme should not be nil")
}

provider, err := apiexport.New(restCfg, apiexport.Options{
providerConfig, err := getPlatformMeshSystemConfig(restCfg)
if err != nil {
setupLog.Error(err, "unable to create provider config")
return err
}
provider, err := apiexport.New(providerConfig, operatorCfg.APIExportEndpointSliceName, apiexport.Options{
Scheme: mgrOpts.Scheme,
})
if err != nil {
Expand Down Expand Up @@ -99,18 +104,11 @@ var modelGeneratorCmd = &cobra.Command{
return err
}

go func() {
if err := provider.Run(ctx, mgr); err != nil {
log.Fatal().Err(err).Msg("unable to run provider")
}
}()

setupLog.Info("starting manager")
if err := mgr.Start(ctrl.SetupSignalHandler()); err != nil {
setupLog.Error(err, "problem running manager")
return err
}

return nil
},
}
43 changes: 31 additions & 12 deletions cmd/operator.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ import (

// Import all Kubernetes client auth plugins (e.g. Azure, GCP, OIDC, etc.)
// to ensure that exec-entrypoint and run can make use of them.
apisv1alpha1 "github.com/kcp-dev/kcp/sdk/apis/apis/v1alpha1"
kcpcorev1alpha1 "github.com/kcp-dev/kcp/sdk/apis/core/v1alpha1"
"github.com/kcp-dev/logicalcluster/v3"
"github.com/kcp-dev/multicluster-provider/apiexport"
kcpapisv1alpha1 "github.com/kcp-dev/sdk/apis/apis/v1alpha1"
kcpcorev1alpha1 "github.com/kcp-dev/sdk/apis/core/v1alpha1"
openfgav1 "github.com/openfga/api/proto/openfga/v1"
accountsv1alpha1 "github.com/platform-mesh/account-operator/api/v1alpha1"
"google.golang.org/grpc"
Expand All @@ -34,7 +34,7 @@ import (
"github.com/platform-mesh/golang-commons/sentry"
"github.com/spf13/cobra"

kcptenancyv1alphav1 "github.com/kcp-dev/kcp/sdk/apis/tenancy/v1alpha1"
kcptenancyv1alphav1 "github.com/kcp-dev/sdk/apis/tenancy/v1alpha1"

corev1alpha1 "github.com/platform-mesh/security-operator/api/v1alpha1"
"github.com/platform-mesh/security-operator/internal/controller"
Expand All @@ -45,8 +45,29 @@ var (
scheme = runtime.NewScheme()
)

const (
platformMeshWorkspace = "root:platform-mesh-system"
)

type NewLogicalClusterClientFunc func(clusterKey logicalcluster.Name) (client.Client, error)

func getPlatformMeshSystemConfig(cfg *rest.Config) (*rest.Config, error) {
providerConfig := rest.CopyConfig(cfg)

parsed, err := url.Parse(providerConfig.Host)
if err != nil {
return nil, fmt.Errorf("unable to parse URL: %w", err)
}

parsed.Path, err = url.JoinPath("clusters", platformMeshWorkspace)
if err != nil {
return nil, fmt.Errorf("failed to join path")
}
providerConfig.Host = parsed.String()

return providerConfig, nil
}

func logicalClusterClientFromKey(mgr ctrl.Manager, log *logger.Logger) NewLogicalClusterClientFunc {
return func(clusterKey logicalcluster.Name) (client.Client, error) {
cfg := rest.CopyConfig(mgr.GetConfig())
Expand Down Expand Up @@ -122,8 +143,12 @@ var operatorCmd = &cobra.Command{
log.Error().Err(fmt.Errorf("scheme should not be nil")).Msg("scheme should not be nil")
return fmt.Errorf("scheme should not be nil")
}

provider, err := apiexport.New(restCfg, apiexport.Options{
providerConfig, err := getPlatformMeshSystemConfig(restCfg)
if err != nil {
setupLog.Error(err, "unable to create provider config")
return err
}
provider, err := apiexport.New(providerConfig, operatorCfg.APIExportEndpointSliceName, apiexport.Options{
Scheme: mgrOpts.Scheme,
})
if err != nil {
Expand Down Expand Up @@ -181,12 +206,6 @@ var operatorCmd = &cobra.Command{
return err
}

go func() {
if err := provider.Run(ctx, mgr); err != nil {
log.Fatal().Err(err).Msg("unable to run provider")
}
}()

setupLog.Info("starting manager")
if err := mgr.Start(ctrl.SetupSignalHandler()); err != nil {
log.Error().Err(err).Msg("problem running manager")
Expand All @@ -201,7 +220,7 @@ func init() {

utilruntime.Must(kcptenancyv1alphav1.AddToScheme(scheme))
utilruntime.Must(corev1alpha1.AddToScheme(scheme))
utilruntime.Must(apisv1alpha1.AddToScheme(scheme))
utilruntime.Must(kcpapisv1alpha1.AddToScheme(scheme))
utilruntime.Must(kcpcorev1alpha1.AddToScheme(scheme))
utilruntime.Must(accountsv1alpha1.AddToScheme(scheme))
// +kubebuilder:scaffold:scheme
Expand Down
11 changes: 5 additions & 6 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ module github.com/platform-mesh/security-operator

go 1.25.0

replace github.com/kcp-dev/multicluster-provider v0.2.0 => github.com/kcp-dev/multicluster-provider v0.0.0-20250827085327-2b5ca378b7b4

require (
github.com/coreos/go-oidc v2.4.0+incompatible
github.com/fluxcd/helm-controller/api v1.4.5
Expand All @@ -12,7 +10,8 @@ require (
github.com/google/gnostic-models v0.7.1
github.com/kcp-dev/kcp/sdk v0.28.1-0.20250926104223-cec2e15f24c6
github.com/kcp-dev/logicalcluster/v3 v3.0.5
github.com/kcp-dev/multicluster-provider v0.2.0
github.com/kcp-dev/multicluster-provider v0.3.3
github.com/kcp-dev/sdk v0.28.1-0.20251209130449-436a0347809b
github.com/openfga/api/proto v0.0.0-20251105142303-feed3db3d69d
github.com/openfga/language/pkg/go v0.2.0-beta.2.0.20251027165255-0f8f255e5f6c
github.com/platform-mesh/account-operator v0.5.53
Expand All @@ -22,7 +21,6 @@ require (
github.com/spf13/viper v1.21.0
github.com/stretchr/testify v1.11.1
golang.org/x/oauth2 v0.34.0
golang.org/x/sync v0.19.0
google.golang.org/grpc v1.78.0
google.golang.org/protobuf v1.36.11
k8s.io/api v0.35.0
Expand All @@ -31,7 +29,7 @@ require (
k8s.io/client-go v0.35.0
k8s.io/utils v0.0.0-20251222233032-718f0e51e6d2
sigs.k8s.io/controller-runtime v0.22.4
sigs.k8s.io/multicluster-runtime v0.21.0-alpha.9
sigs.k8s.io/multicluster-runtime v0.22.4-beta.1
sigs.k8s.io/yaml v1.6.0
)

Expand Down Expand Up @@ -68,7 +66,7 @@ require (
github.com/inconshreveable/mousetrap v1.1.0 // indirect
github.com/josharian/intern v1.0.0 // indirect
github.com/json-iterator/go v1.1.12 // indirect
github.com/kcp-dev/apimachinery/v2 v2.0.1-0.20250728122101-adbf20db3e51 // indirect
github.com/kcp-dev/apimachinery/v2 v2.29.1-0.20251209121225-cf3c0b624983 // indirect
github.com/mailru/easyjson v0.9.0 // indirect
github.com/martinlindhe/base36 v1.1.1 // indirect
github.com/mattn/go-colorable v0.1.14 // indirect
Expand Down Expand Up @@ -109,6 +107,7 @@ require (
golang.org/x/crypto v0.46.0 // indirect
golang.org/x/exp v0.0.0-20251219203646-944ab1f22d93 // indirect
golang.org/x/net v0.48.0 // indirect
golang.org/x/sync v0.19.0 // indirect
golang.org/x/sys v0.39.0 // indirect
golang.org/x/term v0.38.0 // indirect
golang.org/x/text v0.32.0 // indirect
Expand Down
14 changes: 8 additions & 6 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,16 @@ github.com/josharian/intern v1.0.0 h1:vlS4z54oSdjm0bgjRigI+G1HpF+tI+9rE5LLzOg8Hm
github.com/josharian/intern v1.0.0/go.mod h1:5DoeVV0s6jJacbCEi61lwdGj/aVlrQvzHFFd8Hwg//Y=
github.com/json-iterator/go v1.1.12 h1:PV8peI4a0ysnczrg+LtxykD8LfKY9ML6u2jnxaEnrnM=
github.com/json-iterator/go v1.1.12/go.mod h1:e30LSqwooZae/UwlEbR2852Gd8hjQvJoHmT4TnhNGBo=
github.com/kcp-dev/apimachinery/v2 v2.0.1-0.20250728122101-adbf20db3e51 h1:l38RDS+VUMx9etvyaCgJIZa4nM7FaNevNubWN0kDZY4=
github.com/kcp-dev/apimachinery/v2 v2.0.1-0.20250728122101-adbf20db3e51/go.mod h1:rF1jfvUfPjFXs+HV/LN1BtPzAz1bfjJOwVa+hAVfroQ=
github.com/kcp-dev/apimachinery/v2 v2.29.1-0.20251209121225-cf3c0b624983 h1:4hCauFTFMwvIhwL9fqZ5omjeZ+vsOUNO1tLsrCeprxM=
github.com/kcp-dev/apimachinery/v2 v2.29.1-0.20251209121225-cf3c0b624983/go.mod h1:DOv0iw5tcgzFBhudwLFe2WHCLqtlgNkuO4AcqbZ4zVo=
github.com/kcp-dev/kcp/sdk v0.28.1-0.20250926104223-cec2e15f24c6 h1:bOR4mdLD24VCJRrHxmtTh21AdbbzkBBKkEh0ngL+XTc=
github.com/kcp-dev/kcp/sdk v0.28.1-0.20250926104223-cec2e15f24c6/go.mod h1:aC2BPGPvy8QtkI2gQNH9NfW6xpfGIKZkR93gy9O02BE=
github.com/kcp-dev/logicalcluster/v3 v3.0.5 h1:JbYakokb+5Uinz09oTXomSUJVQsqfxEvU4RyHUYxHOU=
github.com/kcp-dev/logicalcluster/v3 v3.0.5/go.mod h1:EWBUBxdr49fUB1cLMO4nOdBWmYifLbP1LfoL20KkXYY=
github.com/kcp-dev/multicluster-provider v0.0.0-20250827085327-2b5ca378b7b4 h1:GUihV22j2J/cGF5Svr/zGVvfqTJepIO+sOnYTn9o4Vc=
github.com/kcp-dev/multicluster-provider v0.0.0-20250827085327-2b5ca378b7b4/go.mod h1:E/NxN2SMtC7b6iXgFMlQYWA7lJIfDPqRkPdvpxOEQLA=
github.com/kcp-dev/multicluster-provider v0.3.3 h1:wTu1Zbk6+kVlB/d/K9TM7KPjUEe/Dg8SYzKQsVDiDFY=
github.com/kcp-dev/multicluster-provider v0.3.3/go.mod h1:4QGU39wyNztoYNatdWqbdOV6/R9ZzaIh4DdSj30dm9o=
github.com/kcp-dev/sdk v0.28.1-0.20251209130449-436a0347809b h1:hPwN5SK3L5bx4Ymeb5NeYN0lqIXd+Xt1cAr3qcSlQxU=
github.com/kcp-dev/sdk v0.28.1-0.20251209130449-436a0347809b/go.mod h1:kdlYfujcotSPrBzwtI6qrsNo4JQ+GB1o04buOfKUo2c=
github.com/klauspost/compress v1.18.0 h1:c/Cqfb0r+Yi+JtIEq73FWXVkRonBlf0CRNYc8Zttxdo=
github.com/klauspost/compress v1.18.0/go.mod h1:2Pp+KzxcywXVXMr50+X0Q/Lsb43OQHYWRCY2AiWywWQ=
github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
Expand Down Expand Up @@ -318,8 +320,8 @@ sigs.k8s.io/controller-runtime v0.22.4 h1:GEjV7KV3TY8e+tJ2LCTxUTanW4z/FmNB7l327U
sigs.k8s.io/controller-runtime v0.22.4/go.mod h1:+QX1XUpTXN4mLoblf4tqr5CQcyHPAki2HLXqQMY6vh8=
sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730 h1:IpInykpT6ceI+QxKBbEflcR5EXP7sU1kvOlxwZh5txg=
sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730/go.mod h1:mdzfpAEoE6DHQEN0uh9ZbOCuHbLK5wOm7dK4ctXE9Tg=
sigs.k8s.io/multicluster-runtime v0.21.0-alpha.9 h1:baonM4f081WWct3U7O4EfqrxcUGtmCrFDbsT1FQ8xlo=
sigs.k8s.io/multicluster-runtime v0.21.0-alpha.9/go.mod h1:CpBzLMLQKdm+UCchd2FiGPiDdCxM5dgCCPKuaQ6Fsv0=
sigs.k8s.io/multicluster-runtime v0.22.4-beta.1 h1:0XWbDINepM9UOyLkqhG4g7BtGBFKCDvZFyPsw1vufKE=
sigs.k8s.io/multicluster-runtime v0.22.4-beta.1/go.mod h1:zSMb4mC8MAZK42l8eE1ywkeX6vjuNRenYzJ1w+GPdfI=
sigs.k8s.io/randfill v1.0.0 h1:JfjMILfT8A6RbawdsK2JXGBR5AQVfd+9TbzrlneTyrU=
sigs.k8s.io/randfill v1.0.0/go.mod h1:XeLlZ/jmk4i1HRopwe7/aU3H5n1zNUcX6TM94b3QxOY=
sigs.k8s.io/structured-merge-diff/v6 v6.3.0 h1:jTijUJbW353oVOd9oTlifJqOGEkUw2jB/fXCbTiQEco=
Expand Down
2 changes: 1 addition & 1 deletion internal/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ type Config struct {
KCP struct {
Kubeconfig string `mapstructure:"kcp-kubeconfig" default:"/api-kubeconfig/kubeconfig"`
} `mapstructure:",squash"`
APIExportEndpointSliceName string `mapstructure:"api-export-endpoint-slice-name"`
APIExportEndpointSliceName string `mapstructure:"api-export-endpoint-slice-name" default:"core.platform-mesh.io"`
CoreModulePath string `mapstructure:"core-module-path"`
WorkspaceDir string `mapstructure:"workspace-dir" default:"/operator/"`
BaseDomain string `mapstructure:"base-domain" default:"portal.dev.local:8443"`
Expand Down
6 changes: 3 additions & 3 deletions internal/controller/apibinding_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import (
"net/url"
"strings"

kcpv1alpha1 "github.com/kcp-dev/kcp/sdk/apis/apis/v1alpha1"
"github.com/kcp-dev/logicalcluster/v3"
kcpapisv1alpha1 "github.com/kcp-dev/sdk/apis/apis/v1alpha1"
platformeshconfig "github.com/platform-mesh/golang-commons/config"
"github.com/platform-mesh/golang-commons/controller/lifecycle/builder"
lifecyclesubroutine "github.com/platform-mesh/golang-commons/controller/lifecycle/subroutine"
Expand Down Expand Up @@ -76,9 +76,9 @@ type APIBindingReconciler struct {

func (r *APIBindingReconciler) Reconcile(ctx context.Context, req mcreconcile.Request) (ctrl.Result, error) {
ctxWithCluster := mccontext.WithCluster(ctx, req.ClusterName)
return r.mclifecycle.Reconcile(ctxWithCluster, req, &kcpv1alpha1.APIBinding{})
return r.mclifecycle.Reconcile(ctxWithCluster, req, &kcpapisv1alpha1.APIBinding{})
}

func (r *APIBindingReconciler) SetupWithManager(mgr mcmanager.Manager, cfg *platformeshconfig.CommonServiceConfig, evp ...predicate.Predicate) error {
return r.mclifecycle.SetupWithManager(mgr, cfg.MaxConcurrentReconciles, "apibinding-controller", &kcpv1alpha1.APIBinding{}, cfg.DebugLabelValue, r, r.log, evp...)
return r.mclifecycle.SetupWithManager(mgr, cfg.MaxConcurrentReconciles, "apibinding-controller", &kcpapisv1alpha1.APIBinding{}, cfg.DebugLabelValue, r, r.log, evp...)
}
2 changes: 1 addition & 1 deletion internal/controller/initializer_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package controller
import (
"context"

kcpcorev1alpha1 "github.com/kcp-dev/kcp/sdk/apis/core/v1alpha1"
kcpcorev1alpha1 "github.com/kcp-dev/sdk/apis/core/v1alpha1"
platformeshconfig "github.com/platform-mesh/golang-commons/config"
"github.com/platform-mesh/golang-commons/controller/lifecycle/builder"
"github.com/platform-mesh/golang-commons/controller/lifecycle/multicluster"
Expand Down
16 changes: 8 additions & 8 deletions internal/subroutine/authorization_model_generation.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import (
"strings"
"text/template"

kcpv1alpha1 "github.com/kcp-dev/kcp/sdk/apis/apis/v1alpha1"
"github.com/kcp-dev/logicalcluster/v3"
kcpapisv1alpha1 "github.com/kcp-dev/sdk/apis/apis/v1alpha1"
accountv1alpha1 "github.com/platform-mesh/account-operator/api/v1alpha1"
lifecyclecontrollerruntime "github.com/platform-mesh/golang-commons/controller/lifecycle/runtimeobject"
lifecyclesubroutine "github.com/platform-mesh/golang-commons/controller/lifecycle/subroutine"
Expand Down Expand Up @@ -87,14 +87,14 @@ type modelInput struct {
func (a *AuthorizationModelGenerationSubroutine) Finalize(ctx context.Context, instance lifecyclecontrollerruntime.RuntimeObject) (ctrl.Result, errors.OperatorError) {
log := logger.LoadLoggerFromContext(ctx)

bindingToDelete := instance.(*kcpv1alpha1.APIBinding)
bindingToDelete := instance.(*kcpapisv1alpha1.APIBinding)

bindingCluster, err := a.mgr.ClusterFromContext(ctx)
if err != nil {
return ctrl.Result{}, errors.NewOperatorError(fmt.Errorf("unable to get cluster from context: %w", err), true, false)
}

var bindings kcpv1alpha1.APIBindingList
var bindings kcpapisv1alpha1.APIBindingList
err = a.allClient.List(ctx, &bindings)
if err != nil {
return ctrl.Result{}, errors.NewOperatorError(err, true, true)
Expand Down Expand Up @@ -149,15 +149,15 @@ func (a *AuthorizationModelGenerationSubroutine) Finalize(ctx context.Context, i
}
apiExportClient := apiExportCluster.GetClient()

var apiExport kcpv1alpha1.APIExport
var apiExport kcpapisv1alpha1.APIExport
err = apiExportClient.Get(ctx, types.NamespacedName{Name: bindingToDelete.Spec.Reference.Export.Name}, &apiExport)
if err != nil {
log.Error().Err(err).Msg("failed to get apiexport for binding deletion")
return ctrl.Result{}, errors.NewOperatorError(err, true, true)
}

for _, latestResourceSchema := range apiExport.Spec.LatestResourceSchemas {
var resourceSchema kcpv1alpha1.APIResourceSchema
var resourceSchema kcpapisv1alpha1.APIResourceSchema
err := apiExportClient.Get(ctx, types.NamespacedName{Name: latestResourceSchema}, &resourceSchema)
if err != nil {
log.Error().Err(err).Msg("failed to get resource schema for binding deletion")
Expand Down Expand Up @@ -198,7 +198,7 @@ func (a *AuthorizationModelGenerationSubroutine) GetName() string {

// Process implements lifecycle.Subroutine.
func (a *AuthorizationModelGenerationSubroutine) Process(ctx context.Context, instance lifecyclecontrollerruntime.RuntimeObject) (ctrl.Result, errors.OperatorError) {
binding := instance.(*kcpv1alpha1.APIBinding)
binding := instance.(*kcpapisv1alpha1.APIBinding)

cluster, err := a.mgr.ClusterFromContext(ctx)
if err != nil {
Expand All @@ -225,14 +225,14 @@ func (a *AuthorizationModelGenerationSubroutine) Process(ctx context.Context, in
return ctrl.Result{}, errors.NewOperatorError(err, true, true)
}

var apiExport kcpv1alpha1.APIExport
var apiExport kcpapisv1alpha1.APIExport
err = apiExportCluster.GetClient().Get(ctx, types.NamespacedName{Name: binding.Spec.Reference.Export.Name}, &apiExport)
if err != nil {
return ctrl.Result{}, errors.NewOperatorError(err, true, true)
}

for _, latestResourceSchema := range apiExport.Spec.LatestResourceSchemas {
var resourceSchema kcpv1alpha1.APIResourceSchema
var resourceSchema kcpapisv1alpha1.APIResourceSchema
err := apiExportCluster.GetClient().Get(ctx, types.NamespacedName{Name: latestResourceSchema}, &resourceSchema)
if err != nil {
return ctrl.Result{}, errors.NewOperatorError(err, true, true)
Expand Down
Loading