Conversation
~ moved indirect access to controller ~ some more consistent nameing changes
+ [docs] also included for how the warning code works
This may come in handy later, but is entirely besides the main point and beyond the scope of the issue.
+ slot factory for quick build ~ more robust factories ~ a way to shut off env + more scripts for testing ~ better slot tests
This reverts commit 1bf2ceb.
This reverts commit 14211ec.
~ changed ScheduleFactory to work with recent changes
Meleeman01
left a comment
Meleeman01
left a comment
There was a problem hiding this comment.
on line 186 of the slotController, you need to change the variable name to $user_name so that your code won't error out.
for the userAllowed function in the SlotController, check for banned members.
and get rid of the spaces in the hrefs in the links of your concurrent slot partials.
after that it should be just fine
| <span> | ||
| @if(isset($admin) && $admin === true) | ||
| {{ $user_name }} is currently signed up for another | ||
| <a href=" {{ env('SITE_URL') }} /slot/{{ $concurrent_slot_id }}/view">overlapping shift</a>. |
There was a problem hiding this comment.
this space in the href url is causing problems, eliminate the space so we can actually see the page. infact all of the hrefs in this portion of the code
| } | ||
| } | ||
|
|
||
| if($slotRoles->isEmpty()) |
There was a problem hiding this comment.
this allows banned users to sign up for shifts. i would rework this logic slightly and check for banned
~ ScheduleFactory now has "volunteer" role by default
Meleeman01
left a comment
Meleeman01
left a comment
There was a problem hiding this comment.
everything seems to be working as intended great job
| <span> | ||
| @if(isset($admin) && $admin === true) | ||
| {{ $user_name }} is currently signed up for another | ||
| <a href=" {{ env('SITE_URL') }} /slot/{{ $concurrent_slot_id }}/view">overlapping shift</a>. |
3 participants
Fixes #113
This is the original solution in #156, with admin warnings enabled.