Open
Conversation
+ tests for the child of event to event method + migration for 'published_at' column on events + tests for authorization of published/unpublished events
+ comments
Meleeman01
requested changes
Sep 22, 2019
Contributor
Meleeman01
left a comment
Meleeman01
left a comment
There was a problem hiding this comment.
works great, but i'm thinking the published unpublished logic should be in the controller
Meleeman01
approved these changes
Sep 27, 2019
Contributor
Meleeman01
left a comment
Meleeman01
left a comment
There was a problem hiding this comment.
everything works as intended, and i understand the design decisions for this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103
This is a much simpler solution compared to #172.
It takes the "CheckedPublished" middleware and if any route concerns itself with viewing anything associated with an unpublished event, a 401 is sent to the user.
An additional "Publish" and "Unpublish" button have been added to the lead and admin event view.