Material migration cleanup #1711
Merged
+9
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abstrakt8
approved these changes
Jan 29, 2026
| // remove shader since physical material is now the default | ||
| if (asset.has('data.shader')) { | ||
| // NOTE: set shader to blinn if it is not already for engine v1 | ||
| if (asset.get('data.shader') !== 'blinn') { |
Contributor
There was a problem hiding this comment.
Why not just get once and cache?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1710
What's Changed
Removes
useGammamigration and updates binding ofuseTonemaptouseGammaTonemapUpdates setting of
shaderto always set toblinnif not already (compatibility with engine V1)I confirm I have read the contributing guidelines