Snapshot API nested list recursive processing#809
Merged
brocollie08 merged 5 commits intomainfrom Mar 4, 2026
Merged
Conversation
sugarmanz
reviewed
Mar 3, 2026
| key to when (value) { | ||
| is Node -> value.snapshot() | ||
| is Function<*> -> null | ||
| is List<*> -> value.map { (it as? Node)?.snapshot() ?: it } |
Member
There was a problem hiding this comment.
We probably want to recurse on Any? here to account for other types, i.e. functions.
…ui/player into public-experimental-snapshot-api
sugarmanz
approved these changes
Mar 3, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #809 +/- ##
==========================================
+ Coverage 85.82% 85.83% +0.01%
==========================================
Files 505 505
Lines 22823 22828 +5
Branches 2657 2660 +3
==========================================
+ Hits 19587 19595 +8
+ Misses 2908 2906 -2
+ Partials 328 327 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bundle ReportChanges will increase total bundle size by 1.89kB (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: plugins/shared-constants/coreAssets Changed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?