Skip to content

Snapshot API nested list recursive processing#809

Merged
brocollie08 merged 5 commits intomainfrom
public-experimental-snapshot-api
Mar 4, 2026
Merged

Snapshot API nested list recursive processing#809
brocollie08 merged 5 commits intomainfrom
public-experimental-snapshot-api

Conversation

@brocollie08
Copy link
Contributor

@brocollie08 brocollie08 commented Mar 3, 2026

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

@brocollie08 brocollie08 changed the title Public experimental snapshot api Snapshot API nested list recursive processing Mar 3, 2026
@brocollie08 brocollie08 marked this pull request as ready for review March 3, 2026 21:48
@brocollie08 brocollie08 requested a review from a team as a code owner March 3, 2026 21:48
key to when (value) {
is Node -> value.snapshot()
is Function<*> -> null
is List<*> -> value.map { (it as? Node)?.snapshot() ?: it }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to recurse on Any? here to account for other types, i.e. functions.

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.83%. Comparing base (181cf0e) to head (5385b86).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ain/kotlin/com/intuit/playerui/core/bridge/Node.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #809      +/-   ##
==========================================
+ Coverage   85.82%   85.83%   +0.01%     
==========================================
  Files         505      505              
  Lines       22823    22828       +5     
  Branches     2657     2660       +3     
==========================================
+ Hits        19587    19595       +8     
+ Misses       2908     2906       -2     
+ Partials      328      327       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov
Copy link

codecov bot commented Mar 4, 2026

Bundle Report

Changes will increase total bundle size by 1.89kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
plugins/shared-constants/core 7.32kB 1.89kB (34.72%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: plugins/shared-constants/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.legacy-esm.js 1.89kB 1.89kB 100.0% ⚠️

@brocollie08 brocollie08 merged commit fdd3250 into main Mar 4, 2026
14 of 15 checks passed
@brocollie08 brocollie08 deleted the public-experimental-snapshot-api branch March 4, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants