Skip to content

implement GraalRuntime::executeRaw #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sugarmanz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

implement GraalRuntime::executeRaw #763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
516c9cc
implement GraalRuntime::executeRaw
sugarmanz Nov 25, 2025
b2222c3
remove outdated comment
sugarmanz Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions jvm/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ kt_jvm_library(
name = "supported_runtimes",
visibility = ["//visibility:public"],
exports = [
# MARK: Disable GraalJS testing
# "//jvm/graaljs",
"//jvm/graaljs",
"//jvm/hermes:hermes-host",
"//jvm/j2v8:j2v8-all",
],
Expand Down
3 changes: 1 addition & 2 deletions jvm/core/src/main/kotlin/com/intuit/playerui/core/bridge/runtime/Runtime.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ public interface Runtime<Value> : Node {
override val format: RuntimeFormat<Value>

@ExperimentalPlayerApi
public fun executeRaw(script: String): Value =
throw UnsupportedOperationException("This experimental method is not implemented for ${this::class.simpleName}")
public fun executeRaw(script: String): Value

/** Execute some arbitrary [script] and return the deserialized result */
public fun execute(script: String): Any?
Expand Down
6 changes: 6 additions & 0 deletions jvm/graaljs/src/main/kotlin/com/intuit/playerui/graaljs/bridge/runtime/GraalRuntime.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import com.intuit.playerui.core.bridge.runtime.PlayerRuntimeFactory
import com.intuit.playerui.core.bridge.runtime.Runtime
import com.intuit.playerui.core.bridge.runtime.ScriptContext
import com.intuit.playerui.core.bridge.serialization.serializers.playerSerializersModule
import com.intuit.playerui.core.experimental.ExperimentalPlayerApi
import com.intuit.playerui.core.player.PlayerException
import com.intuit.playerui.core.utils.InternalPlayerApi
import com.intuit.playerui.graaljs.bridge.GraalNode
Expand Down Expand Up @@ -71,6 +72,11 @@ internal class GraalRuntime(
CoroutineScope(Dispatchers.Default + SupervisorJob() + (config.coroutineExceptionHandler ?: EmptyCoroutineContext))
}

@ExperimentalPlayerApi
override fun executeRaw(script: String): Value = context.blockingLock {
context.eval("js", script)
}

override fun execute(script: String): Any? = context.blockingLock {
context.eval("js", script).handleValue(format)
}
Expand Down