Skip to content

error controller#770

Draft
cehan-Chloe wants to merge 9 commits intomainfrom
error-controller
Draft

error controller#770
cehan-Chloe wants to merge 9 commits intomainfrom
error-controller

Conversation

@cehan-Chloe
Copy link
Contributor

@cehan-Chloe cehan-Chloe commented Dec 9, 2025

Define error controller types and hooks

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

@cehan-Chloe cehan-Chloe marked this pull request as ready for review December 10, 2025 14:00
@cehan-Chloe cehan-Chloe requested a review from a team as a code owner December 10, 2025 14:00
@cehan-Chloe cehan-Chloe marked this pull request as draft December 11, 2025 15:53
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 91.93122% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.02%. Comparing base (e9286b2) to head (07bcf2a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
core/player/src/controllers/flow/flow.ts 76.78% 13 Missing ⚠️
core/player/src/controllers/error/controller.ts 91.24% 12 Missing ⚠️
.../com/intuit/playerui/core/error/ErrorController.kt 75.51% 2 Missing and 10 partials ⚠️
ios/core/Tests/ErrorControllerTests.swift 95.60% 11 Missing ⚠️
ios/core/Tests/Types/HooksTests.swift 91.83% 8 Missing ⚠️
ios/core/Sources/Types/Core/ErrorController.swift 93.87% 3 Missing ⚠️
core/player/src/controllers/error/middleware.ts 96.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #770      +/-   ##
==========================================
+ Coverage   85.82%   86.02%   +0.20%     
==========================================
  Files         505      513       +8     
  Lines       22814    23566     +752     
  Branches     2657     2703      +46     
==========================================
+ Hits        19579    20272     +693     
- Misses       2907     2956      +49     
- Partials      328      338      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov
Copy link

codecov bot commented Dec 11, 2025

Bundle Report

Changes will increase total bundle size by 188.22kB (3.35%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
plugins/beacon/core 417.46kB 15.56kB (3.87%) ⬆️
plugins/check-path/core 435.86kB 15.56kB (3.7%) ⬆️
plugins/stage-revert-data/core 399.48kB 15.56kB (4.05%) ⬆️
plugins/reference-assets/core 478.7kB 15.56kB (3.36%) ⬆️
plugins/common-expressions/core 421.72kB 15.56kB (3.83%) ⬆️
plugins/markdown/core 676.54kB 15.56kB (2.35%) ⬆️
plugins/shared-constants/core 7.32kB 1.89kB (34.72%) ⬆️
plugins/common-types/core 496.05kB 15.56kB (3.24%) ⬆️
plugins/metrics/core 454.03kB 15.56kB (3.55%) ⬆️
plugins/async-node/core 473.52kB 15.56kB (3.4%) ⬆️
core/player 999.07kB 46.27kB (4.86%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: plugins/shared-constants/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.legacy-esm.js 1.89kB 1.89kB 100.0% ⚠️
view changes for bundle: plugins/markdown/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
MarkdownPlugin.native.js 15.56kB 651.39kB 2.45%
view changes for bundle: core/player

Assets Changed:

Asset Name Size Change Total Size Change (%)
Player.native.js 16.99kB 418.68kB 4.23%
cjs/index.cjs 9.89kB 197.86kB 5.26% ⚠️
index.legacy-esm.js 9.7kB 191.26kB 5.34% ⚠️
index.mjs 9.7kB 191.26kB 5.34% ⚠️
view changes for bundle: plugins/beacon/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
BeaconPlugin.native.js 15.56kB 403.0kB 4.02%
view changes for bundle: plugins/stage-revert-data/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
StageRevertDataPlugin.native.js 15.56kB 392.66kB 4.13%
view changes for bundle: plugins/common-expressions/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
CommonExpressionsPlugin.native.js 15.56kB 400.48kB 4.04%
view changes for bundle: plugins/reference-assets/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
ReferenceAssetsPlugin.native.js 15.56kB 448.8kB 3.59%
view changes for bundle: plugins/async-node/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
AsyncNodePlugin.native.js 15.56kB 425.68kB 3.79%
view changes for bundle: plugins/metrics/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
MetricsPlugin.native.js 15.56kB 421.68kB 3.83%
view changes for bundle: plugins/check-path/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
CheckPathPlugin.native.js 15.56kB 406.38kB 3.98%
view changes for bundle: plugins/common-types/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
CommonTypesPlugin.native.js 15.56kB 424.87kB 3.8%

@cehan-Chloe cehan-Chloe requested a review from KetanReddy January 8, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants