Skip to content

[WIP]: render-time error recovery#802

Open
tmarmer wants to merge 5 commits intoerror-controllerfrom
render-error-handling
Open

[WIP]: render-time error recovery#802
tmarmer wants to merge 5 commits intoerror-controllerfrom
render-error-handling

Conversation

@tmarmer
Copy link
Contributor

@tmarmer tmarmer commented Feb 12, 2026

Adding asset error recovery during at runtime and resolve time.

TODO:

  • Add iOS implementation
  • Add/Modify central error types across platforms. Allow for metadata, error type and severity in those errors and read those properties.
  • Catch these errors in the core player promise so all .fail calls use error controller. If no transition or error skip, reject promise as normal.
  • Code cleanup (get rid of all those Maps in async node plugin 💀 )

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs
📦 Published PR as canary version: 0.15.1--canary.802.31569

Try this version out locally by upgrading relevant packages to 0.15.1--canary.802.31569

@tmarmer tmarmer requested review from a team as code owners February 12, 2026 22:16
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 55.55556% with 268 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.14%. Comparing base (07bcf2a) to head (17ce531).

Files with missing lines Patch % Lines
react/player/src/asset/index.tsx 12.50% 70 Missing ⚠️
plugins/async-node/core/src/index.ts 54.62% 54 Missing ⚠️
...nce-assets/core/src/plugins/chat-ui-demo-plugin.ts 32.78% 41 Missing ⚠️
react/player/src/player.tsx 3.12% 31 Missing ⚠️
core/player/src/view/view.ts 45.16% 17 Missing ⚠️
core/player/src/view/resolver/index.ts 92.10% 15 Missing ⚠️
...e-assets/core/src/plugins/error-recovery-plugin.ts 43.47% 13 Missing ⚠️
.../com/intuit/playerui/core/player/HeadlessPlayer.kt 37.50% 8 Missing and 2 partials ⚠️
...rence-assets/core/src/assets/throwing/transform.ts 16.66% 5 Missing ⚠️
...ence-assets/react/src/assets/throwing/Throwing.tsx 28.57% 5 Missing ⚠️
... and 2 more
Additional details and impacted files
@@                 Coverage Diff                  @@
##           error-controller     #802      +/-   ##
====================================================
- Coverage             86.02%   85.14%   -0.88%     
====================================================
  Files                   513      518       +5     
  Lines                 23566    23968     +402     
  Branches               2703     2728      +25     
====================================================
+ Hits                  20272    20407     +135     
- Misses                 2956     3221     +265     
- Partials                338      340       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov
Copy link

codecov bot commented Feb 13, 2026

Bundle Report

Changes will increase total bundle size by 90.21kB (1.56%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
plugins/beacon/core 420.91kB 3.45kB (0.83%) ⬆️
plugins/check-path/core 439.31kB 3.45kB (0.79%) ⬆️
plugins/reference-assets/react 81.84kB 1.37kB (1.71%) ⬆️
plugins/stage-revert-data/core 402.93kB 3.45kB (0.86%) ⬆️
plugins/reference-assets/core 500.38kB 21.67kB (4.53%) ⬆️
react/player 84.92kB 11.56kB (15.76%) ⬆️
plugins/common-expressions/core 425.17kB 3.45kB (0.82%) ⬆️
plugins/markdown/core 679.99kB 3.45kB (0.51%) ⬆️
plugins/reference-assets/components 15.06kB 438 bytes (3.0%) ⬆️
plugins/common-types/core 499.5kB 3.45kB (0.7%) ⬆️
plugins/metrics/core 457.48kB 3.45kB (0.76%) ⬆️
plugins/async-node/core 494.74kB 21.21kB (4.48%) ⬆️
core/player 1.01MB 9.81kB (0.98%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: plugins/metrics/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
MetricsPlugin.native.js 3.45kB 425.13kB 0.82%
view changes for bundle: plugins/reference-assets/react

Assets Changed:

Asset Name Size Change Total Size Change (%)
cjs/index.cjs 499 bytes 26.41kB 1.93%
index.legacy-esm.js 437 bytes 22.45kB 1.99%
index.mjs 437 bytes 22.45kB 1.99%
view changes for bundle: plugins/markdown/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
MarkdownPlugin.native.js 3.45kB 654.84kB 0.53%
view changes for bundle: plugins/async-node/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
AsyncNodePlugin.native.js 10.58kB 436.25kB 2.48%
cjs/index.cjs 3.58kB 20.98kB 20.54% ⚠️
index.legacy-esm.js 3.53kB 18.75kB 23.19% ⚠️
index.mjs 3.53kB 18.75kB 23.19% ⚠️
view changes for bundle: core/player

Assets Changed:

Asset Name Size Change Total Size Change (%)
Player.native.js 3.32kB 422.0kB 0.79%
cjs/index.cjs 2.21kB 200.08kB 1.12%
index.legacy-esm.js 2.14kB 193.4kB 1.12%
index.mjs 2.14kB 193.4kB 1.12%
view changes for bundle: plugins/stage-revert-data/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
StageRevertDataPlugin.native.js 3.45kB 396.11kB 0.88%
view changes for bundle: plugins/common-types/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
CommonTypesPlugin.native.js 3.45kB 428.32kB 0.81%
view changes for bundle: plugins/common-expressions/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
CommonExpressionsPlugin.native.js 3.45kB 403.92kB 0.86%
view changes for bundle: plugins/check-path/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
CheckPathPlugin.native.js 3.45kB 409.83kB 0.85%
view changes for bundle: plugins/reference-assets/components

Assets Changed:

Asset Name Size Change Total Size Change (%)
cjs/index.cjs 182 bytes 6.75kB 2.77%
index.legacy-esm.js 128 bytes 4.16kB 3.18%
index.mjs 128 bytes 4.16kB 3.18%
view changes for bundle: react/player

Assets Changed:

Asset Name Size Change Total Size Change (%)
cjs/index.cjs 3.95kB 30.66kB 14.78% ⚠️
index.legacy-esm.js 3.81kB 27.13kB 16.33% ⚠️
index.mjs 3.81kB 27.13kB 16.33% ⚠️
view changes for bundle: plugins/reference-assets/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
ReferenceAssetsPlugin.native.js 14.47kB 463.27kB 3.22%
cjs/index.cjs 2.44kB 13.63kB 21.83% ⚠️
index.legacy-esm.js 2.38kB 11.74kB 25.46% ⚠️
index.mjs 2.38kB 11.74kB 25.46% ⚠️
view changes for bundle: plugins/beacon/core

Assets Changed:

Asset Name Size Change Total Size Change (%)
BeaconPlugin.native.js 3.45kB 406.44kB 0.86%

@tmarmer
Copy link
Contributor Author

tmarmer commented Feb 13, 2026

/canary

intuit-svc added a commit to player-ui/player-ui.github.io that referenced this pull request Feb 13, 2026
@intuit-svc
Copy link
Contributor

Build Preview

Your PR was deployed by CircleCI #31569 on Fri, 13 Feb 2026 14:55:49 GMT with this version:

0.15.1--canary.802.31569

📖 Docs (View site)

@tmarmer tmarmer requested a review from a team as a code owner February 24, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants