FIX: explicitly do forward declaration on struct for swig file generation#27
Open
mtasaka wants to merge 1 commit intoplayerproject:masterfrom
Open
FIX: explicitly do forward declaration on struct for swig file generation#27mtasaka wants to merge 1 commit intoplayerproject:masterfrom
mtasaka wants to merge 1 commit intoplayerproject:masterfrom
Conversation
…tion Language bindings use files generated by playerc_swig_parse.py which parses header files, and playerc_swig_parse.py deletes the "tag" in struct definition. This behavior generates incomplete struct definition in generated file, then causes compilation error. To avoid compilation error, do explicit forward declaration for such struct. Fixes playerproject#26 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Language bindings use files generated by playerc_swig_parse.py which parses header files, and playerc_swig_parse.py deletes the "tag" in struct definition. This behavior generates incomplete struct definition in generated file, then causes compilation error. To avoid compilation error, do explicit forward declaration for such struct.
Fixes #26 .