Open
Conversation
| Ultimately, be aware that the maintainers don't have much time to dedicate to | ||
| processing pull requests, so the less work they have to do the more likely and | ||
| quickly they can merge those pull requests in. | ||
|
|
Owner
There was a problem hiding this comment.
For future reference, you shouldn't remove this file as GitHub links to it when someone submits a pull request. I'll try to resurrect it locally and push the changes.
Owner
|
Thanks for this contribution! It's very much appreciated. I'm currently trying to sync it with a new feature added with another pull request. Once I'm happy with the implementation of the new feature and the user guide, I'll push the changes. |
Author
|
I've just read this. I'll do the changes asap. |
b36525f to
af2aeb5
Compare
eb58eb3 to
9dd088f
Compare
Author
|
Ok, I've recovered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things to bear in mind:
About the documentation
README,CONTRIBUTING.mdand in theWiki pagesto theasciidoctorpages.READMEwith an introduction about Lazybones and the reference to the documentation and the contribution guidelines.About publishing the documentation
gh-pages, that's why I've added thegh-pages plugin. Once they are publish they should be available atpledbrook.github.io/lazybones.ghPageswill be published executing the commandpublishGhPages. It only requires to have a github api key stored in yourgradle.propertiesaccessible asgithub.tokentemplates.gradleto add the condition of thepublushGhPages. If you check the verification of the task type, I didn't use the class type because it turns out the task is createdon-the-flyso I couln't do 'task instanceof SomeTypeTaskinstead I usedtask.name == 'publishGhPages'`Problems I found:
I'm unable to pass integration tests. I have cloned a clean version of lazybones without any luck. When I checked the results of the tests it seems they are out-of-date because they're receiving different responses than the ones expected. I've never used
betamaxso maybe is something I haven't configured properly.Questions:
At the moment the
contribution guidelinesis saying any new feature should be documented in theREADME. Should I change that kind of this now to point at the new documentation ? If so I would add a new commit to wrap all documentation changes from the original copied from theREADME.Well, that's pretty much it. Don't worry if it takes you some time, I fully understand :)