fix: Ensure pred_links has system_id column for grouping #93
Conversation
src/plinder/data/splits.py
Outdated
| pred_links["system_id"] = pred_links["reference_system_id"] | ||
| assert pred_links is not None, "pred_links is None" | ||
| num_pred_links = pred_links.groupby("query_system").size() | ||
| num_pred_links = pred_links.groupby("system_id").size() |
There was a problem hiding this comment.
@frgoe003 , the pred_links df is not used later - thus assigning system_id seems redundant.
Is there an issue with using query_system variable?
If so, them maybe doing this would be less confusing?
num_pred_links = pred_links.groupby("reference_system_id").size()
There was a problem hiding this comment.
The query_system column is not present in the df. I agree, was just following the apo_links structure. The best way would be to change both groupby operations to reference_system_id.
num_apo_links = apo_links.groupby("reference_system_id").size()
num_pred_links = pred_links.groupby("reference_system_id").size()
There was a problem hiding this comment.
yes, thanks! Please make both reference_system_id and then I think we can merge!
2 participants
No description provided.