Add GeoPermissions exception on synchronous geo permissions error #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vishnukumarpg
approved these changes
Feb 19, 2025
mohsin-plivo
force-pushed
the
sync-geoperms
branch
from
b7a3721 to
1410ca1
Compare
| } catch (GeoPermissionException e) { | ||
| throw e; | ||
| } catch (Exception e) { | ||
| // nop |
Contributor
Author
There was a problem hiding this comment.
Yeah. Throw GeoPermissionException. Any other exception while extracting url, etc will be ignored
narayana-plivo
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.