Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/main/java/com/plivo/api/Plivo.java
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,18 @@ public class Plivo {
* Initializes the global {@link PlivoClient} instance
*/
public static synchronized PlivoClient init(String authId, String authToken) {
instance = new PlivoClient(authId, authToken);
return init(authId, authToken, PlivoClient.BASE_URL);
}

/**
* Initializes the global {@link PlivoClient} instance
*/
public static synchronized PlivoClient init(String authId, String authToken, String baseUrl) {
instance = new PlivoClient(authId, authToken, baseUrl);
return instance;
}


/**
* Initializes the global {@link PlivoClient} instance, taking the authId and authToken from
* environment variables called PLIVO_AUTH_ID and PLIVO_AUTH_TOKEN.
Expand Down
17 changes: 14 additions & 3 deletions src/main/java/com/plivo/api/PlivoClient.java
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,18 @@ public void serialize(Enum value, JsonGenerator gen, SerializerProvider provider
private PlivoAPIService apiService = null;

public PlivoClient(String authId, String authToken) {
this(authId, authToken, new Builder());
this(authId, authToken, BASE_URL, new Builder());
}

public PlivoClient(String authId, String authToken, String baseUrl) {
this(authId, authToken, baseUrl, new Builder());
}

/**
* Constructor left for backward compatibility
*/
public PlivoClient(String authId, String authToken, OkHttpClient.Builder httpClientBuilder) {
this(authId, authToken, BASE_URL, httpClientBuilder);
}

/**
Expand All @@ -117,7 +128,7 @@ public PlivoClient(String authId, String authToken) {
* @param authToken
* @param httpClientBuilder
*/
public PlivoClient(String authId, String authToken, OkHttpClient.Builder httpClientBuilder) {
public PlivoClient(String authId, String authToken, String baseUrl, OkHttpClient.Builder httpClientBuilder) {
if (!(Utils.isAccountIdValid(authId) || Utils.isSubaccountIdValid(authId))) {
throw new IllegalArgumentException("invalid account ID");
}
Expand Down Expand Up @@ -159,7 +170,7 @@ public PlivoClient(String authId, String authToken, OkHttpClient.Builder httpCli

retrofit = new Retrofit.Builder()
.client(httpClient)
.baseUrl(BASE_URL)
.baseUrl(baseUrl)
.addConverterFactory(JacksonConverterFactory.create(objectMapper))
.build();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import com.plivo.api.PlivoClient;
import com.plivo.api.exceptions.PlivoRestException;
import com.plivo.api.models.base.Creator;

import java.io.IOException;

public class CallRecordCreator extends Creator<CallRecordCreateResponse> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@
import com.plivo.api.PlivoClient;
import com.plivo.api.exceptions.PlivoRestException;
import com.plivo.api.models.base.Creator;
import java.io.IOException;
import retrofit2.Call;

import java.io.IOException;

public class ConferenceRecordCreator extends Creator<ConferenceRecordCreateResponse> {

@JsonIgnore
Expand Down
1 change: 0 additions & 1 deletion src/test/java/com/plivo/api/BaseTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ protected void assertRequest(String method, String format, Map<String, String> p
public void setUp() throws Exception {
server = new MockWebServer();
server.start();

PlivoClient.BASE_URL = server.url("/").toString();
Plivo.init(authId, authToken);
Plivo.getClient().setTesting(true);
Expand Down
11 changes: 4 additions & 7 deletions src/test/java/com/plivo/api/CallTest.java
Original file line number Diff line number Diff line change
@@ -1,18 +1,15 @@
package com.plivo.api;

import static junit.framework.TestCase.assertEquals;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.plivo.api.models.call.Call;
import com.plivo.api.models.call.LiveCall;
import com.squareup.okhttp.mockwebserver.RecordedRequest;
import java.util.Arrays;
import java.util.Collections;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.Map;
import org.junit.Test;

import java.util.*;

import static junit.framework.TestCase.assertEquals;

public class CallTest extends BaseTest {

final ObjectMapper objectMapper = new ObjectMapper();
Expand Down