Skip to content

Conversation

@huzaif-plivo
Copy link
Contributor

No description provided.

* @return mixed
*/

public function get_runner($id,$runId)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function name should be getRunner(). Follow the other function name

$phlo = new self($this->client, $id, $this->baseUrl, $runId);
$response = $phlo->client->getPhlorunner($phlo->phlorunnerUrl, []);
return $response->getContent();
//return json_encode($response->getContent(), JSON_FORCE_OBJECT);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this commented code

Copy link
Contributor

@narayana-plivo narayana-plivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add unit case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants