added to_json function #159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
narayana-plivo
left a comment
narayana-plivo
left a comment
There was a problem hiding this comment.
why this change only for two classes?
Contributor
Author
|
We added this function in two classes since we have sdk tests for powerpack and MDR validation cases for messaging stack. |
Contributor
|
@huzaif-plivo Please review this change. |
Contributor
|
@kanishka2104 To check if this supports backward compatability. If not then we will have to re-think. |
narayana-plivo
requested review from
mallika-plivo and
narayana-plivo
and removed request for
narayana-plivo
narayana-plivo
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For converting the response to json, a new function to_json is included