Skip to content

Added tests for add-ons control panel. [5.2]#2299

Merged
gforcada merged 1 commit intomasterfrom
test-addons-control-panel-52
Feb 12, 2018
Merged

Added tests for add-ons control panel. [5.2]#2299
gforcada merged 1 commit intomasterfrom
test-addons-control-panel-52

Conversation

@mauritsvanrees
Copy link
Copy Markdown
Member

And two very minor fixes:

  • Add a link to the Site Setup.
  • Let get_product_version work when you call it with CMFPlacefulWorkflow too.

And two very minor fixes:
- Add a link to the Site Setup.
- Let `get_product_version` work when you call it with `CMFPlacefulWorkflow` too.
@mauritsvanrees
Copy link
Copy Markdown
Member Author

@gforcada I tried two times on Jenkins 5.2 PR, but all robot tests are failing:

WebDriverException:
Message: Can't load the profile. Profile Dir: /tmp/tmpVfL_Bb/webdriver-py-profilecopy
If you specified a log_file in the FirefoxBinary constructor, check it for details.

Did you install geckodriver (or chromedriver) on Jenkins maybe, or did something else that could cause this as side effect? The normal 5.2 Robot test job (so not the PR job) goes just fine.

@gforcada
Copy link
Copy Markdown
Member

gforcada commented Feb 9, 2018

@mauritsvanrees yes, sorry, I did install the gecko driver and updated firefox to version 58, but as selenium is old it does not work. On the pull request to test the newer KGS for p.a.robotframework (plone/buildout.coredev#407) it hangs at some point :-/

I will revert the firefox version bump until we can try to fix the errors.

@mauritsvanrees
Copy link
Copy Markdown
Member Author

No problem. I can see it is tricky test a new KGS with new Firefox and still keep the old tests running.
I reran the job and got different errors. I'll open a different issue.

@mauritsvanrees
Copy link
Copy Markdown
Member Author

Green! :-)

@gforcada gforcada merged commit 6e3cf57 into master Feb 12, 2018
@gforcada gforcada deleted the test-addons-control-panel-52 branch February 12, 2018 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants