Fixes #1501

[codeWithPunith]

• I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
• I verified there aren't any other open pull requests for the same change.
• I followed the guidelines in Contributing to Plone.
• I successfully ran code quality checks on my changes locally.
• I successfully ran tests on my changes locally.
• If needed, I added new tests for my changes.
• If needed, I added documentation for my changes.
• I included a change log entry in my commits.

---

If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #

[codeWithPunith]

The failing CI seems related to GitHub Actions permission when pushing to gh_docs_deploy:
Permission to plone/mockup.git denied to github-actions[bot].
This appears to be a workflow permission issue for fork PRs rather than a code issue.
Could a maintainer please confirm or rerun with proper permissions?

[codeWithPunith]

@petschki Hi! I’ve updated the CHANGES.md entry and fixed the commit message.
The failing docs build is expected because my change is only translations.
Please let me know if anything else is needed. Thanks!

[petschki]

Hi and thank you for your contribution!

Please read this section carefully https://github.com/plone/mockup/blob/master/README.md#commit-style-guide ... you must not edit CHANGES, because its generated with conventional commits.

And please create an issue which gets fixed by this PR and reference to it with a conventional commit.

[codeWithPunith]

Hi and thank you for your time and response @petschki
I was confused because this repo didn't had a news folder ,its been a great help from you
Now all i need to do is that
1.Open an issue solve it
2.Submit it through conventional commit
Am i right on this ?

[petschki]

1. There is already an issue: pat-select2 unable to load pt-br language file #1501 ... please reference to it in the pull request description and in your commit message like fix(pat select2): Fix combined language codes for select2 translations. Fixes #1501 ... you can rename a commit message with git rebase -i upstream/master in your local fork. Read the git instructions carefully for this action.
2. Remove the last 2 commits which modify the CHANGELOG ... you can do that within the same rebase above.

[codeWithPunith]

@petschki i read over your suggestions and I found out like 5 languges that follows xx-YY format in this repo https://github.com/ivaynberg/select2/tree/3.5.4 ...
I thought of solve this like keep an array or set of this 5 Languages and then to capitalize the lang[1] but i felt its dumb way solving this and makes us to add elements to the array whenver this repo gets a update
https://github.com/ivaynberg/select2/tree/3.5.4 ...

Do you any better way which i can implement in the code

[petschki]

@petschki i read over your suggestions and I found out like 5 languges that follows xx-YY format in this repo https://github.com/ivaynberg/select2/tree/3.5.4 ... I thought of solve this like keep an array or set of this 5 Languages and then to capitalize the lang[1] but i felt its dumb way solving this and makes us to add elements to the array whenver this repo gets a update https://github.com/ivaynberg/select2/tree/3.5.4 ...

Do you any better way which i can implement in the code

For this version of mockup, we're stuck with this select2 tag, because we apply some patches for our pat-relateditems ... since pat-relateditems is marked as deprecated, we can move on upgrading select2 to the latest 4.x version and there the translations are a different story in general. So we can fix this here with the list of 5 combined languages (lets not call it dumb ;) and put more effort in upgrading select2.

See my draft PR for upgrading select2 #1295 ... I'd be happy if you can help out there.

[codeWithPunith]

Hi @petschki

I’ve implemented all requested changes for this PR:

• Removed CHANGES.md edits
• Fixed combined language code handling using supported Select2 locales
• Updated commit message to conventional format and referenced pat-select2 unable to load pt-br language file #1501

The PR is aligned with your instructions. However, the GitHub Actions workflow is still failing. Could you please advise if this is expected for this patch, or if there is any additional step I should take to make the workflow pass?

Happy to help with the Select2 upgrade (#1295) in a separate PR if needed.

Thank you!

[codeWithPunith]

hi @petschki

I’ve cleaned up the PR as requested:

• Removed .DS_Store from the PR
• Restored yarn.lock from upstream so there are no dependency changes

Force-pushed the updated commit. Please take a look and let me know if anything else is needed.
(I don't know since the start ,my pr always fails at Deploy docs github action i really don't understand 😓)

Thanks!

[petschki]

Don't care about the documentation tests for now ... this doesn't work for fork PRs ... Thank you!

[petschki]

One more thing: it would be great if you could do the same changes for the maintenance branch 5.4.x here ... then it lands in Plone 6.1.x too ... master branch targets 6.2 only

[codeWithPunith]

One more thing: it would be great if you could do the same changes for the maintenance branch 5.4.x here ... then it lands in Plone 6.1.x too ... master branch targets 6.2 only

hi @petschki
It really be great working under your guidance i would try my best and would be looking up for your inputs

[codeWithPunith]

@petschki
I am thinking like ill do the changes in some new branch (suggest me if any changes are needed) , and what issue number do i need to put is same as this one ?

[petschki]

Of course you need a new branch based on 5.4.x otherwise you have too much stuff from master. Issue number is the same.