Skip to content

Upgrade pat-contentbrowser to Svelte 5 with runes support.#1540

Merged
petschki merged 2 commits intomasterfrom
contentbrowser-svelte-5
Mar 10, 2026
Merged

Upgrade pat-contentbrowser to Svelte 5 with runes support.#1540
petschki merged 2 commits intomasterfrom
contentbrowser-svelte-5

Conversation

@petschki
Copy link
Member

@petschki petschki commented Mar 3, 2026

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes plone/Products.CMFPlone#4261

@petschki petschki force-pushed the contentbrowser-svelte-5 branch from 46f4c6f to 4ca0149 Compare March 3, 2026 15:16
@petschki petschki requested review from MrTango and thet March 3, 2026 15:18
@petschki
Copy link
Member Author

petschki commented Mar 3, 2026

Solved thanks to Claude Sonnet 😉

@petschki petschki force-pushed the contentbrowser-svelte-5 branch 8 times, most recently from 4286b96 to 4ca0149 Compare March 4, 2026 06:20
thet
thet approved these changes Mar 4, 2026
View reviewed changes
Copy link
Member

@thet thet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! needs a rebase on master before merging and probably a new yarn install.

@petschki petschki force-pushed the contentbrowser-svelte-5 branch from 4ca0149 to ac8b72f Compare March 4, 2026 15:42
@petschki

This comment was marked as outdated.

Sign in to view
@petschki petschki force-pushed the contentbrowser-svelte-5 branch from 3bb1fb2 to 8b9cbb1 Compare March 4, 2026 16:25
@petschki
Copy link
Member Author

petschki commented Mar 4, 2026

/run-coredev-robottests

@petschki petschki mentioned this pull request Mar 8, 2026
Merged
@petschki petschki force-pushed the contentbrowser-svelte-5 branch from 8b9cbb1 to 1174fcc Compare March 9, 2026 07:16
@petschki
Copy link
Member Author

petschki commented Mar 9, 2026

/run-coredev-robottests

@petschki petschki force-pushed the contentbrowser-svelte-5 branch from 1174fcc to 4722551 Compare March 9, 2026 09:41
@thet thet force-pushed the contentbrowser-svelte-5 branch from 4722551 to ecbe0e2 Compare March 9, 2026 21:38
@petschki
Copy link
Member Author

petschki commented Mar 10, 2026

/run-coredev-robottests

@petschki petschki merged commit 31ec555 into master Mar 10, 2026
3 checks passed
@petschki petschki deleted the contentbrowser-svelte-5 branch March 10, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thet thet thet approved these changes

@MrTango MrTango Awaiting requested review from MrTango

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PLIP: upgrade pat-contentbrowser to Svelte 5

2 participants

@petschki @thet