Merged
Conversation
b7acb40 to
2593ee0
Compare
The logic to set orderable columns in the structure pattern was quite wrong: - The very first and second-to-last columns were set to no ordering. This PR fixes it to the very first (selection checkboxes) and very last column (actions column). - The very first column was set for a default, ascending ordering. This went unnoticed, as the checkbox cells all have the same order information. This PR sets no initial ordering, as we want the order position in the container set as the default ordering. Fixes: #1551
2593ee0 to
57cd7dd
Compare
Member
|
/run-coredev-robottests |
petschki
approved these changes
Mar 10, 2026
Member
petschki
left a comment
There was a problem hiding this comment.
hm ... somehow I have the feeling my coredev-robottests workflow doesn't use our checkedout plone.staticresources (see https://github.com/plone/mockup/actions/runs/22912898220/job/66490022037#step:13:44) ... need to look that up.
but for this one LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic to set orderable columns in the structure pattern was quite wrong:
The very first and second-to-last columns were set to no ordering. This PR fixes it to the very first (selection checkboxes) and very last column (actions column).
The very first column was set for a default, ascending ordering. This went unnoticed, as the checkbox cells all have the same order information. This PR sets no initial ordering, as we want the order position in the container set as the default ordering.
Fixes: #1551
Now:

Before:
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #