Open
Conversation
The Members folder was never explicitly excluded from navigation. Previously this went unnoticed because the exclude_from_nav indexer silently failed during deferred catalog queue processing (site manager not set). With Products.CMFCore 3.9+ the indexer now works correctly during deferred processing, revealing that the default value (False) was being indexed. Explicitly set exclude_from_nav=True in configure_members_folder(). Refs: plone/buildout.coredev#1080
|
@jensens thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
Member
Author
|
@jenkins-plone-org please run jobs |
2 tasks
Member
Author
|
Note: Jenkins runs against full coredev which still uses CMFCore 3.8 (@mauritsvanrees reverted the pin). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exclude_from_navindexer silently failed during deferred catalog queue processing (site manager not set atbefore_committime), leaving the index empty (None), which didn't matchexclude_from_nav=Falsequeries_ensure_sitefix (Running the tests takes like ages (migration tests & robot tests). #160), the indexer now works correctly, revealing the missing attributeexclude_from_nav=Trueexplicitly inconfigure_members_folder()Refs: plone/buildout.coredev#1080, zopefoundation/Products.CMFCore#160
Test plan
TestCatalogPortalTabs::testCreateTopLevelTabspasses (7 tabs, Members excluded)🤖 Generated with Claude Code