fix(robot): Use element-agnostic XPath for riedit selector#432
Merged
fix(robot): Use element-agnostic XPath for riedit selector#432
Conversation
The recurrence widget's 'Add rules' button was changed from <a> to <button> in plone/mockup#1533 for accessibility. Use //*[@name="riedit"] instead of //a[@name="riedit"] so the test works with both old and new mockup versions.
|
@jensens thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
Member
Author
|
Meta failure is unrelated to this PR. @jenkins-plone-org please run jobs |
Member
Author
|
first get pa.event back in shape with #433 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<a name="riedit">to<button type="button" name="riedit">in fix(a11y): Make recurrence modal fully keyboard-accessible mockup#1533 for keyboard accessibility.//a[@name="riedit"]which no longer matches.//*[@name="riedit"]so it works with both old<a>and new<button>elements.Fixes the broken robot test reported in plone/mockup#1533 (comment).
Test plan
test_event_roundtrip.robotpasses against current mockup