3953 move plone app workflow to plone app layout #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petschki
approved these changes
Feb 13, 2025
Member
petschki
left a comment
petschki
left a comment
There was a problem hiding this comment.
news entry missing, otherwise LGTM
ale-rt
requested changes
Feb 13, 2025
Contributor
Author
|
i added a separate PR #391 for the browserlayer |
MrTango
force-pushed
the
3953-move-plone-app-workflow-to-plone-app-layout
branch
from
c7d575b to
c4fa40c
Compare
17 tasks
ale-rt
requested changes
Feb 14, 2025
Comment on lines
+3
to
+4
| <layer interface="plone.app.layout.interfaces.IPloneAppLayoutLayer" | ||
| name="plone.app.layout" |
Member
There was a problem hiding this comment.
Suggested change
| <layer interface="plone.app.layout.interfaces.IPloneAppLayoutLayer" | |
| name="plone.app.layout" | |
| <layer name="plone.app.layout" |
|
|
||
| <include | ||
| package="plone.app.workflow" | ||
| file="permissions.zcml" |
Member
There was a problem hiding this comment.
Q: should all the package be included?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.