Skip to content

Drop saucelabs#146

Draft
gforcada wants to merge 2 commits intomasterfrom
drop-saucelabs
Draft

Drop saucelabs#146
gforcada wants to merge 2 commits intomasterfrom
drop-saucelabs

Conversation

@gforcada
Copy link
Copy Markdown
Member

@gforcada gforcada commented Jun 27, 2023

As agreed with @datakurre we no longer need this, so we might be better off without it 👍🏾

⚠️ Revisit it once #149 and #145 are merged first.

@mister-roboto
Copy link
Copy Markdown

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@gforcada gforcada marked this pull request as draft June 29, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants