Skip to content

Fix traversal of virtual-hosted subsites#203

Merged
davisagli merged 1 commit intomainfrom
99-fix-vhm-subsite
Apr 1, 2026
Merged

Fix traversal of virtual-hosted subsites#203
davisagli merged 1 commit intomainfrom
99-fix-vhm-subsite

Conversation

@davisagli
Copy link
Copy Markdown
Member

@davisagli davisagli commented Apr 1, 2026

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #99

@mister-roboto
Copy link
Copy Markdown

@davisagli thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@davisagli
Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

@davisagli davisagli force-pushed the 99-fix-vhm-subsite branch from d1ea5e7 to 74655f2 Compare April 1, 2026 17:32
@davisagli davisagli force-pushed the 99-fix-vhm-subsite branch from 74655f2 to d9d3f33 Compare April 1, 2026 17:34
@davisagli davisagli merged commit 7fd25e5 into main Apr 1, 2026
11 checks passed
@davisagli davisagli deleted the 99-fix-vhm-subsite branch April 1, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Traversing RESTWrapper with VirtualHostMonster raises KeyError

2 participants