Skip to content

testing autotoc fixes#386

Closed
petschki wants to merge 2 commits intomasterfrom
release-2.3.2
Closed

testing autotoc fixes#386
petschki wants to merge 2 commits intomasterfrom
release-2.3.2

Conversation

@petschki
Copy link
Member

@petschki petschki commented Jun 24, 2025

this is just a pre-test if the new autotoc Bootstrap markup doesn't break anything ...

EDIT: this needs plone/plone.schemaeditor#139 because of changed markup in robottests

@mister-roboto
Copy link

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@petschki
Copy link
Member Author

@jenkins-plone-org please run jobs

@petschki
Copy link
Member Author

@1letter my local playwright tests passed as I refactored the autotoc Bootstrap implementation. Lets see if jenkins goes green. If so, I'll prep releases for this. Thanks for your robottest fixing branches, but they should not be needed anymore.

@petschki
Copy link
Member Author

@jenkins-plone-org please run jobs

@petschki
Copy link
Member Author

@jenkins-plone-org please run jobs

@petschki petschki closed this Oct 2, 2025
@petschki petschki deleted the release-2.3.2 branch October 2, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants