-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Formatting Updates #5327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Formatting Updates #5327
+33,274
−21,961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes were made to line 2037, in the case where a node is valType info_array in the JSON with dimension: 2 (eg. groups in _node.py line 137). This fixes the issue where markdown interprets it as a hyperlink. This line adds '[][]' to the description after the description passed in the JSON file as part of the validation process. Now, markdown correctly interprets the brackets as consecutive brackets instead.
All three cases in 'InfoArrayValidator' no longer encounter '[][]' errors. For examples, see '_node.py' groups property, '_image.py' zmax property, '_dimension.py' constraintrange property. Keep the newline between "...specified as" and "* ..." to avoid rendering a code block. Note: Python now raises a SyntaxWarning due to '\['.
For examples, see '_annotation.py' property axref.
… into mkdocs-conversion
…ay descriptions for all the cases in info_array which include value types of all cases of enumerated values.
gvwilson
reviewed
Aug 19, 2025
@@ -21,6 +21,9 @@ def fullmatch(regex, string, flags=0): | |||
regex_string = regex | |||
return re.match("(?:" + regex_string + r")\Z", string, flags=flags) | |||
|
|||
# Constants | |||
INDENT = 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :-)
Example usage: `uv run bin/generate_code.py --codedir /tmp/gen --schema /tmp/plot-schema.json`
feat: allow `--schema path` option to code generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatting Updates