Skip to content

fix(icon size): use px size for svg because problem on firefox with vmin #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mpereira2097 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(icon size): use px size for svg because problem on firefox with vmin #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Project.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
} from '@mozaik/ui'

const AVATAR_SIZE = '12vmin'
const ICON_SIZE = '1.8vmin'
const ICON_SIZE = '17px'

const Container = styled.div`
display: flex;
Expand Down
8 changes: 4 additions & 4 deletions src/components/pipelines/LatestProjectPipeline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ export default class LatestProjectPipeline extends Component {
</InfoItem>
<InfoItem>
<GitBranchIcon
size="1.8vmin"
size="16px"
style={{
display: 'inline-block',
verticalAlign: 'middle',
Expand All @@ -235,7 +235,7 @@ export default class LatestProjectPipeline extends Component {
{apiData.ref}
</ExternalLink>{' '}
<GitCommitIcon
size="1.8vmin"
size="16px"
style={{
display: 'inline-block',
verticalAlign: 'middle',
Expand All @@ -249,7 +249,7 @@ export default class LatestProjectPipeline extends Component {
</InfoItem>
<InfoItem>
<ClockIcon
size="1.8vmin"
size="16px"
style={{
display: 'inline-block',
verticalAlign: 'middle',
Expand All @@ -276,7 +276,7 @@ export default class LatestProjectPipeline extends Component {
<Stage key={stage.name}>
<StageLabel>
<StageIcon
size="1.8vmin"
size="16px"
style={{
display: 'inline-block',
verticalAlign: 'middle',
Expand Down
40 changes: 20 additions & 20 deletions test/components/__snapshots__/Branches.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ exports[`should render as expected 1`] = `
/>
</svg>

3 years ago
4 years ago
</span>
</div>
</div>
Expand Down Expand Up @@ -244,7 +244,7 @@ exports[`should render as expected 1`] = `
/>
</svg>

3 years ago
4 years ago
</span>
</div>
</div>
Expand Down Expand Up @@ -333,7 +333,7 @@ exports[`should render as expected 1`] = `
/>
</svg>

2 years ago
3 years ago
</span>
</div>
</div>
Expand Down Expand Up @@ -422,7 +422,7 @@ exports[`should render as expected 1`] = `
/>
</svg>

2 years ago
3 years ago
</span>
</div>
</div>
Expand Down Expand Up @@ -511,7 +511,7 @@ exports[`should render as expected 1`] = `
/>
</svg>

a year ago
2 years ago
</span>
</div>
</div>
Expand Down Expand Up @@ -600,7 +600,7 @@ exports[`should render as expected 1`] = `
/>
</svg>

a year ago
2 years ago
</span>
</div>
</div>
Expand Down Expand Up @@ -689,7 +689,7 @@ exports[`should render as expected 1`] = `
/>
</svg>

2 years ago
3 years ago
</span>
</div>
</div>
Expand Down Expand Up @@ -778,7 +778,7 @@ exports[`should render as expected 1`] = `
/>
</svg>

2 years ago
3 years ago
</span>
</div>
</div>
Expand Down Expand Up @@ -867,7 +867,7 @@ exports[`should render as expected 1`] = `
/>
</svg>

2 years ago
3 years ago
</span>
</div>
</div>
Expand Down Expand Up @@ -956,7 +956,7 @@ exports[`should render as expected 1`] = `
/>
</svg>

2 years ago
3 years ago
</span>
</div>
</div>
Expand Down Expand Up @@ -1045,7 +1045,7 @@ exports[`should render as expected 1`] = `
/>
</svg>

2 years ago
3 years ago
</span>
</div>
</div>
Expand Down Expand Up @@ -1134,7 +1134,7 @@ exports[`should render as expected 1`] = `
/>
</svg>

2 years ago
3 years ago
</span>
</div>
</div>
Expand Down Expand Up @@ -1223,7 +1223,7 @@ exports[`should render as expected 1`] = `
/>
</svg>

a year ago
3 years ago
</span>
</div>
</div>
Expand Down Expand Up @@ -1312,7 +1312,7 @@ exports[`should render as expected 1`] = `
/>
</svg>

a year ago
2 years ago
</span>
</div>
</div>
Expand Down Expand Up @@ -1401,7 +1401,7 @@ exports[`should render as expected 1`] = `
/>
</svg>

10 months ago
2 years ago
</span>
</div>
</div>
Expand Down Expand Up @@ -1490,7 +1490,7 @@ exports[`should render as expected 1`] = `
/>
</svg>

6 months ago
2 years ago
</span>
</div>
</div>
Expand Down Expand Up @@ -1579,7 +1579,7 @@ exports[`should render as expected 1`] = `
/>
</svg>

6 months ago
2 years ago
</span>
</div>
</div>
Expand Down Expand Up @@ -1668,7 +1668,7 @@ exports[`should render as expected 1`] = `
/>
</svg>

6 months ago
2 years ago
</span>
</div>
</div>
Expand Down Expand Up @@ -1757,7 +1757,7 @@ exports[`should render as expected 1`] = `
/>
</svg>

6 months ago
2 years ago
</span>
</div>
</div>
Expand Down Expand Up @@ -1846,7 +1846,7 @@ exports[`should render as expected 1`] = `
/>
</svg>

5 months ago
2 years ago
</span>
</div>
</div>
Expand Down