Skip to content

Conversation

@MyvTsv
Copy link
Contributor

@MyvTsv MyvTsv commented Oct 25, 2024

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.

Description

  • It fixes !34818
  • adds the ticket_tco field to the table of each object when the user wants to use tickets. This fixes the bug that prevent TCO from being calculated for genericobject.

Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks OK, can you get the customer to validate it?

@MyvTsv MyvTsv requested review from Rom1-B and stonebuzz November 29, 2024 10:06
@stonebuzz stonebuzz requested a review from Rom1-B December 26, 2024 11:55
Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for customer feedback.

@stonebuzz stonebuzz self-requested a review December 26, 2024 14:21
Copy link
Contributor

@stonebuzz stonebuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for customer feedback.

@MyvTsv MyvTsv requested review from Rom1-B and stonebuzz January 15, 2025 10:12
Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still awaiting validation by the client

@MyvTsv
Copy link
Contributor Author

MyvTsv commented Feb 14, 2025

I do not know, the client says that it does not work, but me and 2 people from Teclib tested this corrictif and claim that the patch works correctly on their side.

@stonebuzz
Copy link
Contributor

We'll wait for the customer to validate, keep us informed when you have news

@MyvTsv
Copy link
Contributor Author

MyvTsv commented Feb 27, 2025

Patch works for customer

@stonebuzz stonebuzz requested a review from Rom1-B March 28, 2025 10:04
@stonebuzz stonebuzz merged commit 47d76df into pluginsGLPI:main Mar 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants