Skip to content

fix: fix TARGET_H redefined error#3

Open
VyacheslavSalnikov wants to merge 1 commit intoplume-design:masterfrom
VyacheslavSalnikov:patch-11
Open

fix: fix TARGET_H redefined error#3
VyacheslavSalnikov wants to merge 1 commit intoplume-design:masterfrom
VyacheslavSalnikov:patch-11

Conversation

@VyacheslavSalnikov
Copy link

@VyacheslavSalnikov VyacheslavSalnikov commented Mar 6, 2024 •
edited
Loading

Fixes TARGET_H redefined error.
It adds new TARGET_H instead of properly redefining it as done, e.g. in platform/rdk/src/lib/target/override.mk

fix: fix TARGET_H redefined error
32881c6 
Fixes TARGET_H redefined error. Whole file deleted by the patch demonstrates inconvinient approach
It adds new TARGET_H instead of properly redefining it as done, e.g. in platform/rdk/src/lib/target/override.mk

Signed-off-by: Vyacheslav Salnikov <v.salnikov@inango-systems.com>
@VyacheslavSalnikov
Copy link
Author

VyacheslavSalnikov commented Mar 6, 2024

Issues with this file:

1. Not clear why TARGET_H is defined in src/lib/ovs_mac_learn/override.mk and not in src/lib/target/override.mk since last one looks to be a common place for such adjustments and most suitable one.

2. There is a typo in src/lib/target/override.mk (UNIT_CLFAGS -> UNIT_CFLAGS), supposedly, because of it this file exists.

3. If the typo is fixed, compilation error about TARGET_H redefined will be observed.

4. Due to existence of this file it is not possible to adjust TARGET_H in vendor’s override.mk.

@dejan-pojbic-plume
Copy link

dejan-pojbic-plume commented Mar 11, 2024

Thanks for contribution and we are reviewing internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VyacheslavSalnikov @dejan-pojbic-plume