Skip to content

allow edits for inactive prizes #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yogurtandjam merged 1 commit into from
Oct 31, 2025
Merged

allow edits for inactive prizes #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plume/src/spin/Raffle.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ contract Raffle is Initializable, AccessControlUpgradeable, UUPSUpgradeable {
uint256 value,
uint256 quantity,
string calldata formId
) external onlyRole(ADMIN_ROLE) prizeIsActive(prizeId) {
) external onlyRole(ADMIN_ROLE) {
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the prizeIsActive check allows modification of prize details after the prize lifecycle has completed. This could lead to data integrity issues if prize information (name, value, quantity) is changed after winners have been determined, potentially creating inconsistencies in historical records or audit trails. Consider implementing a more granular permission system that allows editing only specific fields like formId for inactive prizes while restricting changes to core prize attributes.

Copilot uses AI. Check for mistakes.
// Update prize details without affecting tickets or active status
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment states 'without affecting tickets or active status' but this is now misleading since the function can now modify inactive prizes. Update the comment to clarify that this function can edit both active and inactive prizes, or specify which fields should be edited after a prize becomes inactive.

Suggested change
// Update prize details without affecting tickets or active status
// Update prize details (name, description, value, quantity, formId) for both active and inactive prizes without affecting tickets or the active status

Copilot uses AI. Check for mistakes.
Prize storage prize = prizes[prizeId];
prize.name = name;
Expand Down