Fix Azure Login authentication in relay tests workflow

[Copilot]

The Azure Relay Tests workflow was failing because azure/login@v1 doesn't accept client-secret as a standalone parameter. The action requires credentials in JSON format via the creds parameter.

Changes

Workflow (.github/workflows/azure-relay-tests.yml):

• Updated 3 Azure Login steps from individual parameters to JSON credentials:

  # Before
  - name: Azure Login
    uses: azure/login@v1
    with:
      client-id: ${{ secrets.AZURE_CLIENT_ID }}
      tenant-id: ${{ secrets.AZURE_TENANT_ID }}
      subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
      client-secret: ${{ secrets.AZURE_CLIENT_SECRET }}  # Invalid parameter
  
  # After
  - name: Azure Login
    uses: azure/login@v1
    with:
      creds: ${{ secrets.AZURE_CREDENTIALS }}

• Removed unused AZURE_SUBSCRIPTION_ID environment variable (already in JSON)

Documentation:

• Updated azure/docs/SECRETS.md: Primary method now uses single AZURE_CREDENTIALS JSON secret
• Updated azure/docs/MIGRATION_GUIDE.md: Instructions for creating service principal with --sdk-auth
• Updated azure/IMPLEMENTATION_SUMMARY.md: Corrected prerequisites

Required Setup

Repository admin must configure AZURE_CREDENTIALS secret:

az ad sp create-for-rbac \
  --name "pluresdb-github-actions" \
  --role contributor \
  --scopes /subscriptions/{subscription-id} \
  --sdk-auth

Then add the entire JSON output as AZURE_CREDENTIALS secret in GitHub repository settings.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Azure Relay Tests Failed - test</issue_title>
<issue_description>The Azure relay tests failed for the test environment.

Details:

• Workflow: Azure Relay Tests
• Run ID: 20888287721
• Environment: test
• Node Count: 3

Please review the workflow logs:
https://github.com/plures/pluresdb/actions/runs/20888287721

Next Steps:

1. Review test failures in the workflow logs
2. Check Azure container logs for errors
3. Verify network connectivity between nodes
4. Review recent code changes that may have affected P2P relay

Related Documentation:

• Test Plan
• Architecture
  </issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Azure Relay Tests Failed - test #35

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.