Open
Conversation
Color became a packed struct(u32) with tag+payload but tests still passed bare hex integers (0xFF0000). Replace with Color.RED etc. Also fix terminal_frame_ptr() return type: u32 → usize for 64-bit. All 41 terminal_wasm tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Colorwas refactored fromu24topacked struct(u32)with tag+payload, but terminal tests still pass bare hex integers (0xFF0000), causing 15 compile errors.terminal_frame_ptr()returnsu32but@intFromPtrproducesusizeon 64-bit, causing 1 more error.Fix
Color.RED,Color.BLACK,Color.WHITE, etc.Color{ .tag = .srgb, .payload = 0xABCDEF }for non-standard colorsterminal_frame_ptr()return type tousizeResult
Build summary improves from 796/797 → 797/797 tests passing (for terminal module).