Skip to content

Fix audio streams#12

Merged
plusuncold merged 3 commits intoplusuncold:masterfrom
tomhense:fix-audio-streams
Feb 13, 2025
Merged

Fix audio streams#12
plusuncold merged 3 commits intoplusuncold:masterfrom
tomhense:fix-audio-streams

Conversation

@tomhense
Copy link
Contributor

@tomhense tomhense commented Feb 8, 2025

tomhense and others added 2 commits February 8, 2025 21:37
… encoding is done in parallel and then the encoded segments are merged.
@plusuncold
Copy link
Owner

Hi, this is great - a solid improvement.

Is there's a requirement to remove pydub to make this work? Only that the poetry.lock needs to be updated in lock-step. So either you'll need to update that file using poetry lock or take out the change to pyproject.toml.

One other change is could you move the ffmpeg call back to multiline? It makes the linter happy and helps on small screens.

@tomhense
Copy link
Contributor Author

There is no requirement to remove pydub it's just technically not needed anymore. But I put it back into pyproject.toml in the lastest commit. The ffmpeg call is now also a bit prettier formatted.

@plusuncold plusuncold merged commit f82a49d into plusuncold:master Feb 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants