Fix audio streams#12
Merged
plusuncold merged 3 commits intoplusuncold:masterfrom Feb 13, 2025
tomhense:fix-audio-streams
Merged
Fix audio streams#12plusuncold merged 3 commits intoplusuncold:masterfrom tomhense:fix-audio-streams
plusuncold merged 3 commits intoplusuncold:masterfrom
tomhense:fix-audio-streams
Conversation
Contributor
tomhense
commented
Feb 8, 2025
- Fixes issue Output file contains two audio streams #10
- Makes encoding much faster by using ffmpeg and encoding in parallel
… encoding is done in parallel and then the encoded segments are merged.
Owner
|
Hi, this is great - a solid improvement. Is there's a requirement to remove pydub to make this work? Only that the poetry.lock needs to be updated in lock-step. So either you'll need to update that file using One other change is could you move the ffmpeg call back to multiline? It makes the linter happy and helps on small screens. |
Contributor
Author
|
There is no requirement to remove pydub it's just technically not needed anymore. But I put it back into pyproject.toml in the lastest commit. The ffmpeg call is now also a bit prettier formatted. |
plusuncold
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.