Merged
Conversation
pmbstyle
commented
Apr 6, 2026
Owner
Author
There was a problem hiding this comment.
Overall: Solid PR. Clean architecture, follows the Google connector pattern, comprehensive MCP server. Ship it.
What looks good 👍
- Connector lifecycle mirrors Google perfectly — status/configure/authorize/start/disconnect
- CLI refactor — Google-specific prompts moved inside the right branch,
--tokenoption for scripting - Error chain in
get_status()covers all real failure modes - Pure normalization functions instead of methods — clean separation
- Honest docs about what's not supported yet
Concerns (follow-ups, not blockers)
forget_credentialsparam unused indisconnect()— always clears token regardless of the flag value- Token passed as env var to subprocess — visible via
/procon shared Linux hosts - No scope validation —
authorize()checks token validity but doesn't verify scopes match enabled services - First commit is a monolith — future PRs benefit from splitting by layer (connector / MCP server / CLI / config)
- No
max_resultscap on list endpoints — could return massive responses for repos with thousands of issues/PRs
Minor nits
- Alphabetical ordering in
manager.py✅ - Service validation in
configure.py✅ - "Stored credentials" wording fix ✅
Verdict
Ship it. The concerns above are follow-up material, not merge blockers. Nice work 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing