chore: apply checkstyle to build-tools as well

[adangel]

See discussion: pmd/pmd#5875 (comment)

[Pankraz76]

it there no pmd parent like seen in maven-parent?

[Pankraz76]

yes, but no. Why is there no (SSOT) parent doing this like in maven?

Now we having this problem 2 times, in maintenance and replacing it with the next tool.

• https://github.com/apache/maven-parent/blob/f4ab7c2eb04865071186c57a263243c72b6e8d52/pom.xml#L1212

[adangel]

it there no pmd parent like seen in maven-parent?
yes, but no. Why is there no (SSOT) parent doing this like in maven?

We didn't need it yet. But at some point, we should think about it. Right now, this repository (build-tools) only contains the configuration (like checkstyle) and some fixes for surefire/kotest/junit, but not the maven-configuration (like as a parent pom). You know maybe, that PMD doesn't have so many modules like apache/apache maven, so it is not entirely unmanageable.

Now we having this problem 2 times, in maintenance and replacing it with the next tool.

Sorry, but nobody except you wants to switch tools... We didn't agree yet on any decision going forward.

[Pankraz76]

Sorry, but nobody except you wants to switch tools... We didn't agree yet on any decision going forward.
Here's a more polished version of your message while maintaining its essence and urgency:

Subject: Need to Address Systemic Issues Rather Than Symptomatic Fixes

Software is called "software" for a reason—it's meant to evolve and adapt.

The current setup has been broken for 7 years. We keep patching symptoms instead of fixing the root cause, which is fundamentally flawed by design.

The problem? Nobody enforces the rules. I seem to be the only fool, paying attention to them, while everyone else—likely smarter than me—ignores the config and contribution guidelines entirely. Why? Because they’re probably outdated, rendering the entire process a waste of time for the entire project.

If we want real progress, we need to:

1. Update and enforce guidelines (or scrap them if they’re irrelevant).
2. Fix the root cause, not just the symptoms.
3. Align the team on whether these rules still matter.

Otherwise, we’re just perpetuating a broken system.

[Pankraz76]

you have 3 options for fix the issue which is:

• https://github.com/revelc/formatter-maven-plugin
• https://github.com/openrewrite
• https://github.com/diffplug/spotless

everything else is just a waste of time, as its not fixing upfront and check seems not to care about the import config ether.

So you really should fix check to enforce all the config you propagate, then you good to go. But still left with annoying whitespace fixes not being made. The Checkstyle IDE plugin can only highlight but not fix them. Still imposing burden on the dev to make some interaction fixing it.

Why not leverage the computer to compute all the issues we want to see fixed and use the proper tooling which bringst me to the beginning of the post:

you have 3 options for fix the issue which is:

• https://github.com/revelc/formatter-maven-plugin
• https://github.com/openrewrite
• https://github.com/diffplug/spotless

everything else is just a waste of time, as its not fixing upfront and check seems not to care about the import config ether.