Conversation
|
See also: pmndrs/drei#2455 Note running |
|
Hey thanks! But shouldn't we bump the versions in package.json also and not just the lock file? |
So yes, it might seem wrong at first but I believe this is correct (or at least, just as viable and more specific) because it's not a direct dep and since drei doesn't enforce the higher stdlib, updating the package.json (you could just run Ultimately though it's up to you! 😄 I totally get if you prefer a broader update that goes beyond just touching the lockfile as I get that can seem off. Given this is also my first PR here I opted for smallest diff / greatest specificity here. If you prefer I update drei recursively that works for me. Thanks! |
|
Oh I see what you mean now. Sure, let's try it this way for now and we can take it from there. |
Dep tree had a mismatch, see: mrdoob/three.js#30934 and pmndrs/three-stdlib#419. Having the older stdlib made freshly cloned/installed repo fail when running commands such as
pnpm run app boidsI opted to just bump the stdlib to the version that had the fix, rather than the latest version available as that felt safer 😛
Note also that some lines re react types got updated as well, which makes the diff less clean than I would have liked but these appear to be in keeping with the dep specification.
Running with this diff allowed me to run the examples on a new machine without error, as I was able to previously.
Thanks!