Skip to content

[WIP] v3.0 more semantic options and a11y features #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

[WIP] v3.0 more semantic options and a11y features #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
644ede5
2.2.0-alpha.1
AlaricBaraou Jun 28, 2021
96b9283
shorter nested dom
AlaricBaraou Jul 14, 2021
1e8cf0b
fix cursor pointer when canvas hidden
AlaricBaraou Jul 14, 2021
c0506a7
add custom attributes to generated dom
AlaricBaraou Jul 14, 2021
c923240
fix useMemo dep
AlaricBaraou Jul 14, 2021
d065122
specify parent tag for A11y
AlaricBaraou Jul 14, 2021
81a975a
update example with latest props
AlaricBaraou Jul 14, 2021
42c0fe2
deepcheck custom el attributes in dep
AlaricBaraou Jul 14, 2021
077e7ac
test
AlaricBaraou Jul 14, 2021
2d975f8
test
AlaricBaraou Jul 14, 2021
2eb0d05
use children for HTML
AlaricBaraou Jul 14, 2021
69bae8c
test
AlaricBaraou Jul 14, 2021
a1b94f9
usememo for parentprop
AlaricBaraou Jul 14, 2021
c3c29a4
test
AlaricBaraou Jul 14, 2021
a1ae375
test
AlaricBaraou Jul 14, 2021
10eacb9
test
AlaricBaraou Jul 14, 2021
abb09fd
test
AlaricBaraou Jul 14, 2021
433eeea
test
AlaricBaraou Jul 15, 2021
33ea6a3
test
AlaricBaraou Jul 15, 2021
33321bc
test
AlaricBaraou Jul 15, 2021
873a853
test
AlaricBaraou Jul 15, 2021
7dfe751
remove test
AlaricBaraou Jul 15, 2021
4d94c5e
hide group when hidden
AlaricBaraou Jul 15, 2021
e0909f2
fix append order
AlaricBaraou Jul 15, 2021
344955d
role type input
AlaricBaraou Jul 15, 2021
8ed2b57
use existing HTML
AlaricBaraou Jul 25, 2021
0983e93
save
AlaricBaraou Jul 25, 2021
09a0e26
remove deprecated components
AlaricBaraou Jul 25, 2021
9190bab
change text only when set
AlaricBaraou Jul 25, 2021
cb99546
fix bind
AlaricBaraou Jul 25, 2021
4f30c7e
test
AlaricBaraou Jul 25, 2021
baeb896
test
AlaricBaraou Jul 25, 2021
1b54a14
useEffectdep
AlaricBaraou Jul 25, 2021
dccafe2
useEffectdep
AlaricBaraou Jul 25, 2021
a52f413
fix overlaying html position
AlaricBaraou Jul 27, 2021
648fe89
cleaning and remove auto display none
AlaricBaraou Jul 27, 2021
84d7697
clean
AlaricBaraou Jul 27, 2021
3a48bf2
support older browser with MediaQueryList
AlaricBaraou Sep 29, 2021
d3a0b81
2.2.0
AlaricBaraou Sep 29, 2021
aec36da
2.2.1
AlaricBaraou Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions example/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,57 @@
</head>

<body>
<header>
<button id="mainimg" aria-controls="mainnav" aria-expanded="false" role="menuitem" tabindex="0">
PICK YOUR STARTER
</button>
<h1>STARTER SELECTION</h1>
<nav>
<ul role="menu">
<li role="none">
<button aria-controls="mainnav" aria-expanded="false" role="menuitem" tabindex="0">
PICK YOUR STARTER
</button>
</li>
<ul id="mainnav">
<li role="none">
<a href="/">GRASS TYPE</a>
</li>
<li>
<a href="/red">FIRE TYPE</a>
</li>
<li>
<a href="/blue">WATER TYPE</a>
</li>
</ul>
</ul>
</nav>
</header>
<form>
<fieldset>
<legend>
<p>Select option</p>
</legend>
<label>
Large
<input tabindex="0" type="radio" name="sizeoption" value="large" checked="" />
</label>
<label>
Medium
<input tabindex="0" type="radio" name="sizeoption" value="medium" />
</label>
<label>
Small
<input tabindex="0" type="radio" name="sizeoption" value="small" />
</label>
</fieldset>
</form>
<div>
<button tabindex="0">rotate left</button>
</div>
<div>
<button tabindex="0">rotate right</button>
</div>
<div id="root"></div>
<script src="./src/index.js"></script>
</body>
Expand Down
38 changes: 18 additions & 20 deletions example/public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
<!DOCTYPE html>
<html lang="en">

<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
<meta name="theme-color" content="#000000">
<!--
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no" />
<meta name="theme-color" content="#000000" />
<!--
manifest.json provides metadata used when your web app is added to the
homescreen on Android. See https://developers.google.com/web/fundamentals/engage-and-retain/web-app-manifest/
-->
<link rel="manifest" href="%PUBLIC_URL%/manifest.json">
<link rel="shortcut icon" href="%PUBLIC_URL%/favicon.ico">
<!--
<link rel="manifest" href="%PUBLIC_URL%/manifest.json" />
<link rel="shortcut icon" href="%PUBLIC_URL%/favicon.ico" />
<!--
Notice the use of %PUBLIC_URL% in the tags above.
It will be replaced with the URL of the `public` folder during the build.
Only files inside the `public` folder can be referenced from the HTML.
Expand All @@ -20,15 +19,15 @@
work correctly both with client-side routing and a non-root public URL.
Learn how to configure a non-root public URL by running `npm run build`.
-->
<title>React App</title>
</head>
<title>React App</title>
</head>

<body>
<noscript>
You need to enable JavaScript to run this app.
</noscript>
<div id="root"></div>
<!--
<body>
<noscript>
You need to enable JavaScript to run this app.
</noscript>
<div id="root"></div>
<!--
This HTML file is a template.
If you open it directly in the browser, you will see an empty page.

Expand All @@ -38,6 +37,5 @@
To begin the development, run `npm start` or `yarn start`.
To create a production bundle, use `npm run build` or `yarn build`.
-->
</body>

</html>
</body>
</html>
Loading