Solved Issue #124 The underlines are not correctly displayed in RTL #125
Open
uniyeh wants to merge 1 commit intopnarimani:masterfrom
Open
Solved Issue #124 The underlines are not correctly displayed in RTL #125uniyeh wants to merge 1 commit intopnarimani:masterfrom
uniyeh wants to merge 1 commit intopnarimani:masterfrom
Conversation
…tead of reversing with TMPro.
uniyeh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the underline displaying issue by self-implementing reversing the text instead of reversing with TMPro.
Detailed implementation:
isRightToLeftTextand added anenableRTLboolean member to replace it.DrawTextInput()to handle RTL text without setting values form_IsRightToLeftPropandm_RtlText.finalText.Reverse()in RTLTestMeshPro.cs since TMPro no longer reverses the text.RichTextFixer.Fix(output)method to correct the order of RichTextTags by swapping the positions of<tag>and</tag>.I also added a scene named "Underline" for reference.
