Open
Conversation
avoid StringBuilder resize due to capacity
hk1ll3r
requested changes
Jun 20, 2022
Collaborator
hk1ll3r
left a comment
hk1ll3r
left a comment
There was a problem hiding this comment.
I'm not sure if this tradeoff between space and exec time is desired.
If you have the time to compute the string length from UTF32 code points in a helper method like ComputeStringLength(), we can use that here.
|
|
||
| public override string ToString() { | ||
| StringBuilder sb = new StringBuilder(); | ||
| StringBuilder sb = new StringBuilder(length * 2); |
Collaborator
There was a problem hiding this comment.
Ideally we should set the capacity to the eventual length of the string which we could compute by replicating the surrogate pair logic in our code. 2*length is an upper bound and allocates twice as much memory as is needed in most cases.
| public string ToDebugString() | ||
| { | ||
| StringBuilder sb = new StringBuilder(); | ||
| StringBuilder sb = new StringBuilder(length * 3); |
Collaborator
There was a problem hiding this comment.
Let's not worry about performance of debug code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToStringavoid StringBuilder resize due to capacityToDebugStringchang append (string) -> append(char)