Conversation
8838e48 to
4839148
Compare
|
Applied ./pflow -netfile for three different files, including Hawaii 40 https://electricgrids.engr.tamu.edu/hawaii40/. |
|
Here is what I am getting with the updated PSSE parser. The case The file that should trigger failure, Question: Why are we throwing an exception after reading poorly structured input? We could just return. |
55e2afe to
9eadd6c
Compare
|
A few questions not specific to changes:
|
| Error("PSS(R)E parser: Encountered duplicate bus name: " + | ||
| buses_[i].name); |
There was a problem hiding this comment.
Bus numbers have to be unique, bus names can be not unique, because they carry the names of towns or cities, and if two different states have a town called “Gainesville”, then you can have bus 123456 “Gainesville” and 678901 “Gainesville”, suggest to remove the check for unique bus names.
There was a problem hiding this comment.
Sounds good. It looks like other components can refer to buses by name ("extended bus id") rather than number. That's why I had that requirement. So should I assume that all bus references in the file will use the bus number?
There was a problem hiding this comment.
I believe that "extended bus id" is used mainly for output. For computations, I would assume that bus number is used as a unique bus id.
CC @abhyshr
There was a problem hiding this comment.
From the docs:
1.2. Extended Bus Names
On its Bus Data record, each bus is assigned a bus number and a 12 character alphanumeric name. When the bus names input option of activity READ is enabled, data fields designating buses on load, fixed shunt, generator, non-transformer branch, transformer, area, two-terminal dc line, VSC dc line, multi-terminal dc line, multi-section line, FACTS device, switched shunt, GNE device, and induction machine, data records may be specified as either extended bus names enclosed in single quotes or as bus numbers.
What I hear you both saying is we should not allow this. All the listed component types should designate buses by integer id. Am I correct?
There was a problem hiding this comment.
I think this is correct.
@abhyshr, do you want to chime in?
118d243 to
6e38f73
Compare
I copied this logic from here.
This was also copied from the original reader. It combines the logic used for both branches and transformers here. I see that My goal has been to reproduce the result of the original reader. Any changes needed will be for you experts to decide. 😺 And I'll be happy to implement them. |
Merge request type
Relates to
This MR updates
Summary
Multiple improvements to PSSE parser:
PS)load.areadefaults to area of bus referenced byload.i)Linked Issue(s)