Skip to content

Upgrade to Spack v1.1.1 and related fixes.#196

Merged
pelesh merged 46 commits intodevelopfrom
nicholson/spack-v1.1
Feb 5, 2026
Merged

Upgrade to Spack v1.1.1 and related fixes.#196
pelesh merged 46 commits intodevelopfrom
nicholson/spack-v1.1

Conversation

@nkoukpaizan
Copy link
Collaborator

@nkoukpaizan nkoukpaizan commented Jan 29, 2026

Merge request type

  • New feature
  • Resolves bug
  • Documentation
  • Other

Relates to

  • OPFLOW
  • SOPFLOW
  • SCOPFLOW
  • TCOPFLOW
  • CMake build system
  • Spack configuration
  • Manual
  • Web docs
  • Other

This MR updates

  • Header files
  • Source code
  • CMake build system
  • Spack configuration
  • Web docs
  • Manual
  • Other

Summary

This upgrades the Spack submodule to v1.1.1 and deprecates incompatible build configurations (deception, newell and incline) that are not being tested with the new configuration.

  • With the Spack upgrade, now pointing to upstream Spack and using local Spack repos for modified packages that have yet to be contributed upstream. I plan to submit appropriate PRs to spack-packages once we know this works.
  • Updated Frontier modules accordingly. romcc is no longer a supported compiler, and mixes compiler modules are deprecated on Frontier. The only way to get a performant Fortran compiler for coinhsl, etc., and support HIP is to load PrgEnv-gnu and rocm. So, most packages are built built withgcc unless there is HIP code.
  • Moved deprecated configurations to deprecated folders with corresponding README files.

Linked Issue(s)

@nkoukpaizan nkoukpaizan self-assigned this Jan 29, 2026
@nkoukpaizan nkoukpaizan added enhancement New feature or request spack-build labels Jan 29, 2026
@pelesh
Copy link
Collaborator

pelesh commented Jan 29, 2026

CC @cameronrutherford

@nkoukpaizan
Copy link
Collaborator Author

@cameronrutherford Do you know a fix for the error I'm seeing?

Error: invalid push configuration for mirror local-buildcache: environment variable `***` (secret_variable) not set

Everything is building fine, but the push to the container registry is not working.

@nkoukpaizan nkoukpaizan force-pushed the nicholson/spack-v1.1 branch 2 times, most recently from ea3b5fd to 021f9dd Compare January 30, 2026 19:55
@nkoukpaizan
Copy link
Collaborator Author

@cameronrutherford Do you know a fix for the error I'm seeing?

Error: invalid push configuration for mirror local-buildcache: environment variable `***` (secret_variable) not set

Everything is building fine, but the push to the container registry is not working.

Finally figured out a way to make it work!

@nkoukpaizan nkoukpaizan marked this pull request as ready for review January 30, 2026 21:25
Copy link
Collaborator

@cameronrutherford cameronrutherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some NITs, some other more interesting comments.

@cameronrutherford
Copy link
Collaborator

LGTM if CI passes. I'm sure you'll get a better review from a maintainer about the package.py recipe anyway.

@nkoukpaizan nkoukpaizan marked this pull request as draft February 5, 2026 00:05
@nkoukpaizan
Copy link
Collaborator Author

nkoukpaizan commented Feb 5, 2026

I fixed several issues related to running the tests in GH-Actions (e.g., detecting the maximum number of available cores for testing in parallel, fixing test dependencies in CMake when some EXAGO_ENABLE_* options are off). Now, we can also build against ipopt~coinhsl+mumps ^mumps+mpi.

I documented the main remaining issues in #201. I suggest we keep the Test build stage of GH-Actions commented out for now.

@nkoukpaizan nkoukpaizan marked this pull request as ready for review February 5, 2026 01:25
@pelesh pelesh self-requested a review February 5, 2026 21:20
@pelesh pelesh merged commit 6f04993 into develop Feb 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request spack-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants