Open
Conversation
- Project description - Cursor directives
The videoCabinet component was attempting to connect to offline video servers, causing errors. Updated the availableInstances() method in roy.js to filter out both old and offline servers, preventing connection attempts to servers marked as online: false in the bastyon-peertubes repository.
Fixed inverted comparison operator (== to !=) in removeInstance() that caused memory leak by keeping removed instances instead of filtering them out.
Added reference validation and defensive checks in addInstance(), removeInstance(), and destroy() to prevent counter operations on deleted/replaced instance records.
Added state validation checks to prevent requests, stats access, and server
selection on destroyed instances. Returns safe defaults or clear error codes
('INSTANCE_DESTROYED', 'INSTANCE_NOT_USABLE') instead of undefined behavior.
Made instance.init() properly async by awaiting getinfo() and only setting inited=true on success. Added cleanup on failure (clear interval, destroy statistic). Log failures in roy.js without blocking instance creation.
Added self.instanses = {} and inited = false to destroy() to properly reset
state. Prevents stale instance references across restarts that caused counter
desynchronization and memory leaks.
This reverts commit 459b700. The async initialization approach was causing issues with instance availability. Reverting to synchronous initialization pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standards checklist:
Changes:
Other comments:
...