Skip to content

Rewrite context and make various fixes#18

Merged
tankakatan merged 5 commits intomainfrom
fix/PZ-516
Nov 2, 2022
Merged

Rewrite context and make various fixes#18
tankakatan merged 5 commits intomainfrom
fix/PZ-516

Conversation

@Koochr
Copy link
Contributor

@Koochr Koochr commented Nov 1, 2022

No description provided.

Copy link
Contributor

@michelnapo michelnapo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Koochr I tested the version and the only problem that I found was when I deleted the post I cannot see it in the trash. Other things are all working. The code is ok. Just remember that we have PRs #16, #17 and #14 open, which fix bugs and add features. Maybe would be better to merge then before this PR. Otherwise the modifications could be difficult to integrate.

@Koochr
Copy link
Contributor Author

Koochr commented Nov 2, 2022

@Koochr I tested the version and the only problem that I found was when I deleted the post I cannot see it in the trash. Other things are all working. The code is ok. Just remember that we have PRs #16, #17 and #14 open, which fix bugs and add features. Maybe would be better to merge then before this PR. Otherwise the modifications could be difficult to integrate.

Thanks, I've fixed.
Regarding other PRs - I've rewritten all the context, so it let's do it in reverse order, first merge this one, and then I'll include #16 and #14 manually.
Regarding #17 - I don't understand, what sense does it make? And how is it connected with deleted blogs?

@tankakatan tankakatan requested a review from michelnapo November 2, 2022 14:57
@tankakatan tankakatan merged commit 896716f into main Nov 2, 2022
@tankakatan tankakatan deleted the fix/PZ-516 branch November 2, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants