This repository was archived by the owner on May 14, 2021. It is now read-only.
Set nginx dependency to ~> 2.4.4#18
Open
chrishas35 wants to merge 1 commit intopoise:masterfrom
Open
Conversation
Nginx cookbook commit sous-chefs/nginx@094685b has broken the way nginx_load_balancer is generating templates.
Contributor
|
👍 Unfortunately this is a backwards incompatible change in the nginx cookbook in a minor release... Any thoughts @someara or @trinitronx? This breaks because it ends up expecting a |
benlangfeld
added a commit
to mojolingo/adam_cookbook
that referenced
this pull request
Apr 3, 2014
Author
|
A pull request has been added to opscode-cookbooks/nginx to fix the backwards incompatible change as well. sous-chefs/nginx#207. If/when that is merged, this dependency fallback shouldn't be necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nginx cookbook 2.5.0 has changed the way this cookbook's nginx_load_balancer is expecting to generate templates using nginx_site. Commit: sous-chefs/nginx@094685b
The proper fix is probably to adjust nginx_load_balancer, but this quick dependency changes solves the problem for me and may be useful to others until a full patch is made.