Add latency to lobby listings
#285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`latency` contains the average latency to all the peers in the lobby. This can be useful to filter on or sort by to find lobbies weer peers close to you.
erikdubbelboer
force-pushed
the
latency
branch
from
5f07419 to
e6626fa
Compare
Caspervw
requested changes
Oct 17, 2025
|
|
||
| var lobbies []Lobby | ||
| rows, err := s.DB.Query(ctx, ` | ||
| WITH lobbies AS ( |
There was a problem hiding this comment.
NIT: "lobbies" is also the table name, that might be confusing
| latency += Math.round((performance.now() - start) / 2) // Divide by 2 to estimate one-way latency. | ||
| } | ||
|
|
||
| return Math.round(latency / pings) // Average of two measurements. |
Comment on lines
+429
to
+456
| now := util.NowUTC(ctx) | ||
|
|
||
| if len(latency) == 0 { | ||
| _, err := s.DB.Exec(ctx, ` | ||
| UPDATE peers | ||
| SET | ||
| latency_vector = NULL, | ||
| updated_at = $1 | ||
| WHERE peer = $2 | ||
| `, now, peerID) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } else { | ||
| _, err := s.DB.Exec(ctx, ` | ||
| UPDATE peers | ||
| SET | ||
| latency_vector = $1, | ||
| updated_at = $2 | ||
| WHERE peer = $3 | ||
| `, pgvector.NewVector(latency), now, peerID) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
Can we combine this?
var latencyVec pgvector.Vector
if len(latency) > 0 {
latencyVec = pgvector.NewVector(latency)
}
_, err := s.DB.Exec(ctx, `
UPDATE peers
SET
latency_vector = $1,
updated_at = $2
WHERE peer = $3
`, latencyVec, now, peerID)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
latencycontains the average latency to all the peers in the lobby. This can be useful to filter on or sort by to find lobbies weer peers close to you.