-
Notifications
You must be signed in to change notification settings - Fork 74
update hardhat documentation for web0 hackathon #1227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update hardhat documentation for web0 hackathon #1227
Conversation
nhussein11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks @UtkarshBhardwaj007 !
One minor thing, in line #36, we should change from pointing to https://faucet.polkadot.io/?parachain=1111 to just https://faucet.polkadot.io/, right? So people then select AssetHub manually, since the rpc we are showing is https://testnet-passet-hub-eth-rpc.polkadot.io
Thanks @nhussein11 , I think it's better to directly link to the faucet for |
Makes sense then, successfully tested all the commands. Many thanks! π This now is ready for the @polkadot-developers/docs-formatting-team |
dawnkelly09
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions after running through Grammarly. Thank you for your contribution!
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
Thanks @dawnkelly09 , accepted all suggestions. Could you please review again and merge please? Hoping to get this in before tomorrow as sub0 starts tomorrow. |
dawnkelly09
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π’
991cf5f
into
polkadot-developers:master
π Description
Updated to use latest hardhat version + EVM backend + latest nodes release
π Review Preference
Choose one:
π€ AI-Ready Docs
If content changed, regenerate AI files:
python3 scripts/generate_llms.pyβ Checklist
Closes #1228