Skip to content

ENG-1191: Shadow for table when overflow #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
timmyjose wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ENG-1191: Shadow for table when overflow #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 39 additions & 3 deletions site/src/components/ResultsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useState } from 'react'
import { useRef, useState, useEffect } from 'react'
import Image from 'next/image'
import NextLink from 'next/link'
import {
Expand Down Expand Up @@ -312,6 +312,32 @@ export function ResultsTable() {
metric: metrics.find((a) => a.id === metric)?.prop,
cost: metric === 'cost',
}
const tableRef = useRef<HTMLDivElement | null>(null)
const [shadow, setShadow] = useState("")

const handleScroll = (e: any) => {
if (tableRef.current) {
const { scrollLeft, scrollWidth, clientWidth } = tableRef.current

if (scrollLeft <= 0) {
setShadow('right')
} else if (scrollWidth - scrollLeft === clientWidth) {
setShadow('left')
} else {
setShadow('both')
}
}
}

useEffect(() => {
if (tableRef.current) {
const tableElement = tableRef.current
tableElement.addEventListener('scroll', handleScroll)
return () => {
tableElement.removeEventListener('scroll', handleScroll)
}
}
}, [])

return (
<Stack fontSize='sm' spacing={4}>
Expand Down Expand Up @@ -347,8 +373,18 @@ export function ResultsTable() {
})}
</HStack>
</HStack>
<Box border='1px solid' borderBottomWidth={0} borderColor='bw.100' borderRadius={5}>
<TableContainer overflowX="unset" overflowY="unset">
<Box
border='1px solid'
borderBottomWidth={0}
borderColor='bw.100'
borderRadius={5}
boxShadow={
shadow === 'right' ? '5px 0px 15px rgba(0,0,0,0.2)' :
shadow === 'left' ? '-5px 0px 15px rgba(0,0,0,0.2)' :
shadow === 'both' ? '5px 0px 15px rgba(0,0,0,0.2), -5px 0px 15px rgba(0,0,0,0.2)' : 'none'
}
>
<TableContainer ref={tableRef} overflowX="auto" overflowY="unset">
<Table>
<Thead>
<Tr>
Expand Down