Fix Slack image upload: scope, WS limit, error propagation#32
Merged
DorianZheng merged 1 commit intomainfrom Mar 20, 2026
Merged
Fix Slack image upload: scope, WS limit, error propagation#32DorianZheng merged 1 commit intomainfrom
DorianZheng merged 1 commit intomainfrom
Conversation
…ate errors
- Add files:write to the copy-manifest scopes in settings UI
- Raise WebSocket maxPayload to 16 MB so base64-encoded images are not
rejected by the ws library's default 1 MB limit
- Make sendImageToSlack propagate errors instead of silently swallowing
them, so the RPC caller gets a real failure instead of { ok: true }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
files:writescope to the copy-manifest button in settings UImaxPayloadfrom default 1 MB to 16 MB so base64-encoded images can pass through the RPC transportsendImageToSlackpropagate errors to the RPC caller instead of silently returning{ ok: true }Test plan
files:writeis included in scopesslack-send-image.shand confirm it arrives in Slack{ ok: true }