Fix .port file path resolution in dev mode#36
Merged
DorianZheng merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
ca0780d changed getBackendPort() to read join(__dirname, '../.port'), which resolves correctly from dist/index.js but incorrectly from src/agents/agent-manager.ts (one level too deep → src/.port instead of packages/backend/.port). Centralize portFilePath in config.ts using backendPackageRoot so both server.ts and agent-manager.ts always resolve to the same path regardless of source layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
portFilePathinconfig.tsusingbackendPackageRootso the.portfile path is consistent across all consumersagent-manager.tsresolvedjoin(__dirname, '../.port')tosrc/.portinstead ofpackages/backend/.portin dev mode, causingDUNE_WS_URLto not be set for agentsTest plan
make buildpassesmake dev, start an agent, verifyDUNE_WS_URLis set in the agent's environment